[DevTools] Avoid uncached Promise when symbolicating sources in environments without file fetching #34224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
sebmarkbage
approved these changes
Aug 17, 2025
eps1lon
force-pushed
the
sebbie/08-17-_devtools_avoid_uncached_promise_when_symbolicating_sources_in_environments_without_file_fetching
branch
from
90a3125 to
1ae97f1
Compare
…onments without file fetching
eps1lon
force-pushed
the
sebbie/08-17-_devtools_avoid_uncached_promise_when_symbolicating_sources_in_environments_without_file_fetching
branch
from
1ae97f1 to
4280a9b
Compare
eps1lon
deleted the
sebbie/08-17-_devtools_avoid_uncached_promise_when_symbolicating_sources_in_environments_without_file_fetching
branch
This was referenced Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #34208
Returning
Promise.resolve(null)fromuseMemois effectively returning an uncached Promise.Mostly a fix for developing in the DevTools fixture I believe.
CleanShot.2025-08-17.at.19.36.23.mp4