[DevTools] Handle reorders when resuspending while fallback contains Suspense #34225
+284
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
changed the title
eps1lon
changed the title
github-actions
bot
added
the
React Core Team
eps1lon
force-pushed
the
sebbie/08-17-_devtools_handle_reorders_when_resuspending_while_fallback_contains_suspense
branch
2 times, most recently
from
7a3d4ad to
9c1313b
Compare
hoxyq
approved these changes
Aug 18, 2025
eps1lon
force-pushed
the
sebbie/08-17-_devtools_handle_reorders_when_resuspending_while_fallback_contains_suspense
branch
from
9c1313b to
a459ca5
Compare
eps1lon
deleted the
sebbie/08-17-_devtools_handle_reorders_when_resuspending_while_fallback_contains_suspense
branch
unstubbable
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 20, 2025
[diff facebook/react@0bdb9206...03fda05d](facebook/react@0bdb920...03fda05) <details> <summary>React upstream changes</summary> - facebook/react#34237 - facebook/react#34236 - facebook/react#34234 - facebook/react#34225 </details>
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Aug 23, 2025
…Suspense (facebook#34225) DiffTrain build for [ae5c2f8](facebook@ae5c2f8)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Aug 23, 2025
…Suspense (facebook#34225) DiffTrain build for [ae5c2f8](facebook@ae5c2f8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #34224
This is reverting #34168 in favor of passing the designated parent to
removePreviousSuspendedBy.We can't just pop the Suspense nodes after we updated the fallback since the fallback might've inserted a new Suspense node i.e. advanced sibling pointers.
We now no longer pop after reconciling Suspense fallbacks. Callers need to know they don't need to pop when they reconciled Suspense children.