Skip to content

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Aug 19, 2025

error-stack-parser can return undefined in parsed function names while we expect null for bottom values instead. We need to choose the right bottom value before we consider it a ReactStackTrace

@meta-cla meta-cla bot added the CLA Signed label Aug 19, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Aug 19, 2025
"hookSource": {
"columnNumber": 0,
"fileName": "**",
"functionName": null,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was undefined before

@react-sizebot
Copy link

react-sizebot commented Aug 19, 2025

Comparing: ae5c2f8...cf6c100

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.18 kB 530.18 kB = 93.39 kB 93.39 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 655.81 kB 655.81 kB = 115.30 kB 115.30 kB
facebook-www/ReactDOM-prod.classic.js = 675.58 kB 675.58 kB = 118.54 kB 118.54 kB
facebook-www/ReactDOM-prod.modern.js = 666.00 kB 666.00 kB = 116.86 kB 116.86 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.production.js +2.62% 28.95 kB 29.70 kB +1.27% 5.73 kB 5.80 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.production.js +2.62% 28.95 kB 29.70 kB +1.27% 5.73 kB 5.80 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.production.js +2.62% 28.95 kB 29.70 kB +1.27% 5.73 kB 5.80 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js +2.46% 32.49 kB 33.29 kB +1.25% 5.85 kB 5.92 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js +2.46% 32.49 kB 33.29 kB +1.25% 5.85 kB 5.92 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.development.js +2.46% 32.49 kB 33.29 kB +1.25% 5.85 kB 5.92 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-debug-tools/cjs/react-debug-tools.production.js +2.62% 28.95 kB 29.70 kB +1.27% 5.73 kB 5.80 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.production.js +2.62% 28.95 kB 29.70 kB +1.27% 5.73 kB 5.80 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.production.js +2.62% 28.95 kB 29.70 kB +1.27% 5.73 kB 5.80 kB
oss-experimental/react-debug-tools/cjs/react-debug-tools.development.js +2.46% 32.49 kB 33.29 kB +1.25% 5.85 kB 5.92 kB
oss-stable-semver/react-debug-tools/cjs/react-debug-tools.development.js +2.46% 32.49 kB 33.29 kB +1.25% 5.85 kB 5.92 kB
oss-stable/react-debug-tools/cjs/react-debug-tools.development.js +2.46% 32.49 kB 33.29 kB +1.25% 5.85 kB 5.92 kB

Generated by 🚫 dangerJS against cf6c100

@eps1lon eps1lon force-pushed the sebbie/anon-use-inspection branch from 9390298 to bf2bd04 Compare August 19, 2025 19:38
@eps1lon eps1lon force-pushed the sebbie/anon-use-inspection branch from bf2bd04 to cf6c100 Compare August 19, 2025 19:54
@eps1lon eps1lon marked this pull request as ready for review August 19, 2025 19:59
@eps1lon eps1lon requested a review from hoxyq August 19, 2025 19:59
@eps1lon eps1lon merged commit 3e20dc8 into facebook:main Aug 20, 2025
244 checks passed
@eps1lon eps1lon deleted the sebbie/anon-use-inspection branch August 20, 2025 08:11
github-actions bot pushed a commit to nikeee/react that referenced this pull request Aug 20, 2025
github-actions bot pushed a commit to nikeee/react that referenced this pull request Aug 20, 2025
unstubbable pushed a commit to vercel/next.js that referenced this pull request Aug 20, 2025
github-actions bot pushed a commit to code/lib-react that referenced this pull request Aug 23, 2025
github-actions bot pushed a commit to code/lib-react that referenced this pull request Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants