-
Notifications
You must be signed in to change notification settings - Fork 49.5k
[DevTools] Fix crash when inspecting Components suspended on data awaited in anonymous functions #34234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+161
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Aug 19, 2025
"hookSource": { | ||
"columnNumber": 0, | ||
"fileName": "**", | ||
"functionName": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was undefined
before
Comparing: ae5c2f8...cf6c100 Critical size changesIncludes critical production bundles, as well as any change greater than 2%: Significant size changesIncludes any change greater than 0.2%: Expand to show
|
9390298
to
bf2bd04
Compare
…ited in anonymous functions
bf2bd04
to
cf6c100
Compare
hoxyq
approved these changes
Aug 19, 2025
github-actions bot
pushed a commit
to nikeee/react
that referenced
this pull request
Aug 20, 2025
…ited in anonymous functions (facebook#34234) DiffTrain build for [3e20dc8](facebook@3e20dc8)
github-actions bot
pushed a commit
to nikeee/react
that referenced
this pull request
Aug 20, 2025
…ited in anonymous functions (facebook#34234) DiffTrain build for [3e20dc8](facebook@3e20dc8)
unstubbable
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 20, 2025
[diff facebook/react@0bdb9206...03fda05d](facebook/react@0bdb920...03fda05) <details> <summary>React upstream changes</summary> - facebook/react#34237 - facebook/react#34236 - facebook/react#34234 - facebook/react#34225 </details>
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Aug 23, 2025
…ited in anonymous functions (facebook#34234) DiffTrain build for [3e20dc8](facebook@3e20dc8)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Aug 23, 2025
…ited in anonymous functions (facebook#34234) DiffTrain build for [3e20dc8](facebook@3e20dc8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error-stack-parser
can returnundefined
in parsed function names while we expectnull
for bottom values instead. We need to choose the right bottom value before we consider it aReactStackTrace