[DevTools] Elevate Suspense rects to visualize hierarchy #34455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
force-pushed
the
sebbie/09-10-_devtools_elevate_suspense_rects_to_visualize_hierarchy
branch
from
e9074d6 to
958cc57
Compare
eps1lon
force-pushed
the
sebbie/09-10-_devtools_elevate_suspense_rects_to_visualize_hierarchy
branch
2 times, most recently
from
c3c237f to
71928dd
Compare
sebmarkbage
approved these changes
Sep 18, 2025
It's misleading unless it would be an actual polygon
eps1lon
force-pushed
the
sebbie/09-10-_devtools_elevate_suspense_rects_to_visualize_hierarchy
branch
from
71928dd to
a10e706
Compare
eps1lon
deleted the
sebbie/09-10-_devtools_elevate_suspense_rects_to_visualize_hierarchy
branch
This was referenced Sep 19, 2025
unstubbable
pushed a commit
to vercel/next.js
that referenced
this pull request
Sep 19, 2025
[diff facebook/react@84af9085...d415fd3e](facebook/react@84af908...d415fd3) <details> <summary>React upstream changes</summary> - facebook/react#34536 - facebook/react#34534 - facebook/react#34531 - facebook/react#34499 - facebook/react#34523 - facebook/react#34511 - facebook/react#34516 - facebook/react#34455 - facebook/react#34488 - facebook/react#34521 </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now show boundaries as slightly elevated by using a CSS
box-shadow. This should help visualize hierarchy.Had to switch to using
<div>instead of<svg>since the box shadow filter in CSS would scale with theviewbox. For the stroke we usednon-scaling-stroketo get a 1px outline but a similar trick doesn't seem available for SVGfilter.The scaling is still the same (i.e. we stretch the bbox of the roots to the available width of the Suspense tab and preserve aspect ratio of the bbox of the roots)
The dark mode variant may be a bit too subtle. Though it doesn't need to be apparent that there is a box shadow. The UI just needs to feel like there's elevation.
CleanShot.2025-09-12.at.10.25.39.mp4