Skip to content

Conversation

unstubbable
Copy link
Collaborator

In an upstack PR, I need getDebugInfo in another test file, so I'm moving it to internal-test-utils so it can be shared.

@meta-cla meta-cla bot added the CLA Signed label Sep 18, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Sep 18, 2025
@react-sizebot
Copy link

react-sizebot commented Sep 18, 2025

Comparing: 03a96c7...8a89e30

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 534.28 kB 534.28 kB = 94.31 kB 94.31 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 663.61 kB 663.61 kB = 116.99 kB 116.99 kB
facebook-www/ReactDOM-prod.classic.js = 687.53 kB 687.53 kB = 121.02 kB 121.02 kB
facebook-www/ReactDOM-prod.modern.js = 677.95 kB 677.95 kB = 119.37 kB 119.37 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 8a89e30

Copy link
Collaborator

@sebmarkbage sebmarkbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that it's not all the same in all test files because they're testing different things. E.g. ReactFlightAsyncDebugInfo has a different version.

@unstubbable
Copy link
Collaborator Author

unstubbable commented Sep 18, 2025

Note that it's not all the same in all test files because they're testing different things. E.g. ReactFlightAsyncDebugInfo has a different version.

What do you mean? The extracted version is the one from ReactFlightAsyncDebugInfo. EDIT: Oh I see the two other ones now. Somehow missed those. I'll see whether we can consolidate them.

In an upstack PR, I need `getDebugInfo` in another test file, so I'm
moving it to `internal-test-utils` so it can be shared.
@unstubbable unstubbable force-pushed the extract-debug-info-test-utils branch from 3987ab6 to 8a89e30 Compare September 18, 2025 18:38
@unstubbable
Copy link
Collaborator Author

Note that it's not all the same in all test files because they're testing different things. E.g. ReactFlightAsyncDebugInfo has a different version.

What do you mean? The extracted version is the one from ReactFlightAsyncDebugInfo. EDIT: Oh I see the two other ones now. Somehow missed those. I'll see whether we can consolidate them.

@sebmarkbage I've now consolidated all three of them. Wanna take a second look?

@sebmarkbage
Copy link
Collaborator

sebmarkbage commented Sep 18, 2025

Well my point is that I did not want to consolidate them necessarily because I filter out stuff from the snapshots that want to assert elsewhere. EDIT: I guess you solved this with an option for this case but seems a bit fragile. It's effectively what it already does though because I haven't thought of a better strategy.

@sebmarkbage
Copy link
Collaborator

It's mostly theoretical because we're not asserting on it but like byteSize of the stream and start/end is something we should be testing in general but not in the snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants