-
Notifications
You must be signed in to change notification settings - Fork 49.5k
Move getDebugInfo
test util function to internal-test-utils
#34523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move getDebugInfo
test util function to internal-test-utils
#34523
Conversation
Comparing: 03a96c7...8a89e30 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that it's not all the same in all test files because they're testing different things. E.g. ReactFlightAsyncDebugInfo has a different version.
What do you mean? The extracted version is the one from |
In an upstack PR, I need `getDebugInfo` in another test file, so I'm moving it to `internal-test-utils` so it can be shared.
3987ab6
to
8a89e30
Compare
@sebmarkbage I've now consolidated all three of them. Wanna take a second look? |
Well my point is that I did not want to consolidate them necessarily because I filter out stuff from the snapshots that want to assert elsewhere. EDIT: I guess you solved this with an option for this case but seems a bit fragile. It's effectively what it already does though because I haven't thought of a better strategy. |
It's mostly theoretical because we're not asserting on it but like byteSize of the stream and start/end is something we should be testing in general but not in the snapshots. |
[diff facebook/react@84af9085...d415fd3e](facebook/react@84af908...d415fd3) <details> <summary>React upstream changes</summary> - facebook/react#34536 - facebook/react#34534 - facebook/react#34531 - facebook/react#34499 - facebook/react#34523 - facebook/react#34511 - facebook/react#34516 - facebook/react#34455 - facebook/react#34488 - facebook/react#34521 </details>
In an upstack PR, I need
getDebugInfo
in another test file, so I'm moving it tointernal-test-utils
so it can be shared.