[DevTools] Fix instrumentation error when reconciling promise-as-a-child #34587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
hoxyq
approved these changes
Sep 24, 2025
eps1lon
deleted the
sebbie/09-24-_devtools_fix_instrumentation_error_when_reconciling_promise-as-a-child
branch
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
unstubbable
pushed a commit
to vercel/next.js
that referenced
this pull request
Sep 25, 2025
[diff facebook/react@e2332183...b0c1dc01](facebook/react@e233218...b0c1dc0) <details> <summary>React upstream changes</summary> - facebook/react#34601 - facebook/react#34552 - facebook/react#34524 - facebook/react#34587 - facebook/react#34589 - facebook/react#34585 - facebook/react#34586 </details>
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Sep 27, 2025
…ild (facebook#34587) DiffTrain build for [c44fbf4](facebook@c44fbf4)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Sep 27, 2025
…ild (facebook#34587) DiffTrain build for [c44fbf4](facebook@c44fbf4)
EugeneChoi4
pushed a commit
to EugeneChoi4/react
that referenced
this pull request
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing suspended-by from a Suspense instance we can't remove it from the parent. This works automatically for inserting since we push the Suspense instance onto the stack before we start reconciling but removal is done afterwards.
We can't pop back after we reconciled the fallback since reconciling the fallback could've advanced sibling pointers (see #34225)