[playground] handle when transformOutput is null #34724
Open
+15
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The React Compiler Playground was crashing for me with a error that said
"Application error: a client-side exception has occurred while loading playground.react.dev"
. I could only fix it by clearing the browser dataConsole error:
Problematic source code:
I tracked this down to a bug that I think should be caught by TypeScript since
CompilerTransformOutput['transformOutput']
is non-nullable. My fix was to move the return statements into thetry
andcatch
blocks. I had something slightly different in an initial fix but I was confused byotherErrors
andhasErrors()
.How did you test this change?
Tested locally. Screen shot attached.