-
Notifications
You must be signed in to change notification settings - Fork 49.6k
[eprh] Prepare for 7.0.0 #34757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eprh] Prepare for 7.0.0 #34757
Conversation
Comparing: 9724e3e...8f8aaab Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
0979326
to
82c636b
Compare
aaf6158
to
48e2f5b
Compare
5bf9531
to
03c6454
Compare
For 7.0.0: Slim down presets to just 2 configurations: - `recommended`: legacy and flat config with all recommended rules, and - `recommended-latest`: legacy and flat config with all recommended rules plus new bleeding edge experimental compiler rules Removed: - `recommended-latest-legacy` - `flat/recommended` Please see the README for new install instructions.
rules: basicRuleConfigs, | ||
}, | ||
'recommended-latest-legacy': { | ||
recommended: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GH code review is bad so i can't comment on the right lines, but last feedback is that we should actually enable different rules in recommended-latest. maybe your no-void-usememo validation?
For 7.0.0: Slim down presets to just 2 configurations: - `recommended`: legacy and flat config with all recommended rules, and - `recommended-latest`: legacy and flat config with all recommended rules plus new bleeding edge experimental compiler rules Removed: - `recommended-latest-legacy` - `flat/recommended` Please see the README for new install instructions. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757). * #34783 * #34782 * __->__ #34757 DiffTrain build for [7568e71](7568e71)
For 7.0.0: Slim down presets to just 2 configurations: - `recommended`: legacy and flat config with all recommended rules, and - `recommended-latest`: legacy and flat config with all recommended rules plus new bleeding edge experimental compiler rules Removed: - `recommended-latest-legacy` - `flat/recommended` Please see the README for new install instructions. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757). * #34783 * #34782 * __->__ #34757 DiffTrain build for [7568e71](7568e71)
For 7.0.0:
Slim down presets to just 2 configurations:
recommended
: legacy and flat config with all recommended rules, andrecommended-latest
: legacy and flat config with all recommended rules plus new bleeding edge experimental compiler rulesRemoved:
recommended-latest-legacy
flat/recommended
Please see the README for new install instructions.
Stack created with Sapling. Best reviewed with ReviewStack.