Skip to content

Conversation

poteto
Copy link
Member

@poteto poteto commented Oct 7, 2025

For 7.0.0:

Slim down presets to just 2 configurations:

  • recommended: legacy and flat config with all recommended rules, and
  • recommended-latest: legacy and flat config with all recommended rules plus new bleeding edge experimental compiler rules

Removed:

  • recommended-latest-legacy
  • flat/recommended

Please see the README for new install instructions.


Stack created with Sapling. Best reviewed with ReviewStack.

@meta-cla meta-cla bot added the CLA Signed label Oct 7, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Oct 7, 2025
@react-sizebot
Copy link

react-sizebot commented Oct 7, 2025

Comparing: 9724e3e...8f8aaab

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 604.98 kB 604.98 kB = 107.14 kB 107.14 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 663.95 kB 663.95 kB = 117.03 kB 117.03 kB
facebook-www/ReactDOM-prod.classic.js = 687.81 kB 687.81 kB = 121.07 kB 121.07 kB
facebook-www/ReactDOM-prod.modern.js = 678.24 kB 678.24 kB = 119.42 kB 119.42 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 8f8aaab

@poteto poteto force-pushed the pr34757 branch 4 times, most recently from 0979326 to 82c636b Compare October 8, 2025 16:52
@poteto poteto force-pushed the pr34757 branch 2 times, most recently from aaf6158 to 48e2f5b Compare October 8, 2025 17:20
@poteto poteto force-pushed the pr34757 branch 2 times, most recently from 5bf9531 to 03c6454 Compare October 8, 2025 17:49
For 7.0.0:

Slim down presets to just 2 configurations:

- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended rules plus new bleeding edge experimental compiler rules

Removed:
- `recommended-latest-legacy`
- `flat/recommended`

Please see the README for new install instructions.
rules: basicRuleConfigs,
},
'recommended-latest-legacy': {
recommended: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GH code review is bad so i can't comment on the right lines, but last feedback is that we should actually enable different rules in recommended-latest. maybe your no-void-usememo validation?

@poteto poteto merged commit 7568e71 into main Oct 8, 2025
241 checks passed
@poteto poteto deleted the pr34757 branch October 8, 2025 19:17
github-actions bot pushed a commit that referenced this pull request Oct 8, 2025
For 7.0.0:

Slim down presets to just 2 configurations:

- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules

Removed:
- `recommended-latest-legacy`
- `flat/recommended`

Please see the README for new install instructions.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757

DiffTrain build for [7568e71](7568e71)
github-actions bot pushed a commit that referenced this pull request Oct 8, 2025
For 7.0.0:

Slim down presets to just 2 configurations:

- `recommended`: legacy and flat config with all recommended rules, and
- `recommended-latest`: legacy and flat config with all recommended
rules plus new bleeding edge experimental compiler rules

Removed:
- `recommended-latest-legacy`
- `flat/recommended`

Please see the README for new install instructions.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34757).
* #34783
* #34782
* __->__ #34757

DiffTrain build for [7568e71](7568e71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants