Skip to content

Conversation

mdj-uk
Copy link

@mdj-uk mdj-uk commented Oct 8, 2025

Summary

Fixes #34779

Also adds instructions for using latest compiler powered rules.

How did you test this change?

@meta-cla meta-cla bot added the CLA Signed label Oct 8, 2025
Copy link
Member

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! We're already working on an update to the readme in #34757 - heads to @poteto in case we want to pull in any content from this PR.

@mdj-uk
Copy link
Author

mdj-uk commented Oct 9, 2025

Closing this as it's now out of date with the release of eprh v7.

Though there's still (imho) an issue with the sample eslint config not working out of the box. See my comment at #34779 (comment). Happy to submit a PR based on that if it's helpful.

PS: nice job everyone on your talks this week - really enjoyed them! And congrats on release of compiler v1.0

@mdj-uk mdj-uk closed this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: eprh README eslint.config.js examples cause parsing errors

2 participants