This repository was archived by the owner on Feb 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
More on range mode and range controller #1178
Merged
appleguy
merged 12 commits into
facebookarchive:master
from
nguyenhuy:range_tuning_params_follow_up
Feb 5, 2016
Merged
More on range mode and range controller #1178
appleguy
merged 12 commits into
facebookarchive:master
from
nguyenhuy:range_tuning_params_follow_up
Feb 5, 2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#pragma mark - Notification observers | ||
|
||
- (void)registerForNotificationsIfNeeded | ||
- (void)registerForNotificationsIfNeededForInterfaceState:(ASInterfaceState)interfaceState |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
registerForNotificationsForInterfaceStateIfNeeded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed. Thanks!
…ditions in ASRangeControllerBeta - Accurately remove notification observer
9497caa
to
80977d1
Compare
80977d1
to
6e68b9c
Compare
6e68b9c
to
a7df20d
Compare
appleguy
added a commit
that referenced
this pull request
Feb 5, 2016
More on range mode and range controller
peter-iakovlev
pushed a commit
to peter-iakovlev/AsyncDisplayKit
that referenced
this pull request
Nov 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #1163
One problem/concern left: Pages are not notified when they fall outside visible range of the hosting pager node. So they don't update their range mode and don't shrink back to minimum one.