This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Added test user garbage collection to test suite #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. |
gfosco
pushed a commit
that referenced
this pull request
Jun 16, 2014
Added test user garbage collection to test suite
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the test suite a bit and added garbage collection of the test user so that our apps don't get maxed out with phpunit test users as was happening in my app.
I also added a tiny tweak to
FacebookRequeststhat tracks the number of requests made to Graph. This is great for debugging. The test suite makes 21 calls to Graph right now FYI. :)I didn't refactor the tests as much as I wanted to since I didn't want to cause any conflicts with #114. So after that one gets merged, I'll send another PR with a better test refactor. And one goal will be to try and decrease the number of requests made to Graph with each test run. :)