Skip to content
This repository was archived by the owner on Jan 13, 2022. It is now read-only.

Conversation

localheinz
Copy link
Contributor

This PR

  • makes use of the class keyword instead of specifying class names by string literals

@yguedidi
Copy link
Contributor

Thank you so much @localheinz!! How did you do that? Is there a tool that do that automatically? :)
@SammyK what do you think about this one?

@localheinz
Copy link
Contributor Author

localheinz commented Jan 16, 2017

@yguedidi

I made use of @kalessil's PhpStorm plugin (see https://github.com/kalessil/phpinspectionsea) and then sorted out a few imports!

@SammyK
Copy link
Contributor

SammyK commented Jan 16, 2017

I'm a huge fan of this since it makes refactoring a breeze with a good IDE. I'm glad the SDK can finally take advantage of this feature since the min PHP version will be 5.6. :) Thanks @localheinz!

@SammyK SammyK merged commit 2f14903 into facebookarchive:master Jan 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants