Better stable rearrange sampling #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort for filter files configured in scene instance config user_defined fields.
…nsistency of support surface from bb corners projected in gravity direction
facebook-github-bot
added
the
CLA Signed
aclegg3
commented
May 1, 2023
Skylion007
reviewed
May 1, 2023
habitat-lab/habitat/datasets/rearrange/run_episode_generator.py
Outdated
Show resolved
Hide resolved
Skylion007
reviewed
May 1, 2023
Skylion007
reviewed
May 1, 2023
Skylion007
approved these changes
May 1, 2023
Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>
…esearch/habitat-lab into better-stable-sampling
5 tasks
Skylion007
reviewed
May 18, 2023
| @@ -39,6 +39,7 @@ def __init__( | |||
| sample_region_ratio: Optional[Dict[str, float]] = None, | |||
| nav_to_min_distance: float = -1.0, | |||
| recep_set_sample_probs: Optional[Dict[str, float]] = None, | |||
| translation_up_offset=0.08, | |||
There was a problem hiding this comment.
Suggested change
| translation_up_offset=0.08, | |
| translation_up_offset : float =0.08, |
Skylion007
approved these changes
May 18, 2023
dannymcy
pushed a commit
to dannymcy/habitat-lab
that referenced
this pull request
Jul 8, 2024
* refactor snapping functionality to improve stability by buffering vertical COM placement height * fix margin issues --------- Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>
HHYHRHY
pushed a commit
to SgtVincent/habitat-lab
that referenced
this pull request
Aug 31, 2024
* refactor snapping functionality to improve stability by buffering vertical COM placement height * fix margin issues --------- Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR adjusts some generator parameters for object placement sampling to enable more robust performance and faster generation times on HSSD.
Primarily this: 1. samples object COM placements about the Receptacle such that raycasts don't begin inside of convex shapes and miss surfaces. 2. better accounts for object margins causing similar issues.
How Has This Been Tested
Tested with rearrange generator on HSSD scenes. MUCH better performance that
main. Episodes generated in 1-2 attempts instead of 10-20 attempts.Locally with habitat-sim 2078.
Types of changes
Checklist