Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Fix bug in detecting if is_pip() #1457

Merged
merged 1 commit into from
Aug 29, 2021
Merged

[bugfix] Fix bug in detecting if is_pip() #1457

merged 1 commit into from
Aug 29, 2021

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

  • This fixes a bug where setup.py would not detect if it was running in pip when run with python -m pip ... . This uses a more robust ENV variable to see if it is being called from setup.py or not.

How Has This Been Tested

  • Locally and on CLI
  • Also removes deprecated setup_requires which was only used as hack anyhow to install pytest automatically when python setup.py test . This argument is deprecated anyway so best to remove and further simplify the script.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project..
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 28, 2021
@Skylion007 Skylion007 merged commit a282700 into master Aug 29, 2021
@Skylion007 Skylion007 deleted the fix_pip_install_bug branch August 29, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikwijmans erikwijmans erikwijmans approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

@eundersander eundersander Awaiting requested review from eundersander

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Skylion007 @erikwijmans @facebook-github-bot