Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bugfix): Remove an extra tmp copy of lightsetup in Simulator.cpp #1867

Merged
merged 1 commit into from
Sep 19, 2022
Merged

(bugfix): Remove an extra tmp copy of lightsetup in Simulator.cpp #1867

merged 1 commit into from
Sep 19, 2022

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

Tiny performance bug in simulator.cpp relating to lighting setup. This removes an unnecessary extra copy.

How Has This Been Tested

  • Locally

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 19, 2022
aclegg3
aclegg3 approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Skylion007 Skylion007 merged commit d9e9e01 into main Sep 19, 2022
@Skylion007 Skylion007 deleted the missing-move-sim-lightsetup branch September 19, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

@eundersander eundersander Awaiting requested review from eundersander

@jrreyna jrreyna Awaiting requested review from jrreyna

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skylion007 @aclegg3 @facebook-github-bot