Rename Factory method to Factory #294
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would agree with the creator of #177
As I understand it - Factory method pattern is about class methods.
Such methods should be implemented or overridden by child classes (in languages where there is no other choice and where classes and functions are not first-class citizens)
refs:
https://python-patterns.guide/gang-of-four/factory-method/
https://en.wikipedia.org/wiki/Factory_method_pattern
I would also list Factory method along with Singleton in anti-patterns section (things to avoid).
Changes from this PR:
factory_method.py
tofactory.py
P.S.: congratulations on 20k stars! 🌟