Added base case and return the path as soon as end node is visited #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techntools
commented
Sep 26, 2020
| node = edge_to[node] | ||
| path.insert(0, start) | ||
| return path | ||
| if end in edge_to.keys(): |
There was a problem hiding this comment.
Using keys() instead values() as do not have to visit the children of end node.
techntools
commented
Sep 26, 2020
| ['G', 'E', 'F'] | ||
|
|
||
| # unreachable node | ||
| >>> print(graph_search.find_path_dfs('C', 'H')) |
techntools
commented
Sep 26, 2020
| None | ||
|
|
||
| # non existing node | ||
| >>> print(graph_search.find_path_dfs('C', 'X')) |
There was a problem hiding this comment.
End node does not exist in graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a base case for BFS like DFS.
No need to use break in loop. Create the path and return it.
Changed the docstests to remove some ambiguity in variable names ( graph vs graph1) and added some more to cover the edge cases.