Skip to content

Add Protocol to factory pattern #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Add Protocol to factory pattern #403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions patterns/creational/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@
*TL;DR
Creates objects without having to specify the exact class.
"""
from typing import Dict
from typing import Protocol
from typing import Type


class Localizer(Protocol):
def localize(self, msg: str) -> str:
pass


class GreekLocalizer:
Expand All @@ -41,10 +49,10 @@ def localize(self, msg: str) -> str:
return msg


def get_localizer(language: str = "English") -> object:
def get_localizer(language: str = "English") -> Localizer:

"""Factory"""
localizers = {
localizers: Dict[str, Type[Localizer]] = {
"English": EnglishLocalizer,
"Greek": GreekLocalizer,
}
Expand Down