Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simplecov requirement from = 0.17.1 to = 0.18.5 #2043

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jun 8, 2020

Updates the requirements on simplecov to permit the latest version.

Release notes

Sourced from simplecov's releases.

v0.18.5

Can you guess? Another bugfix release!

Bugfixes

  • minitest won't crash if SimpleCov isn't loaded - aka don't execute SimpleCov code in the minitest plugin if SimpleCov isn't loaded. Thanks to @edariedl for the report of the peculiar problem in #877.

v0.18.4

Another small bugfix release 🙈 Fixes SimpleCov running with rspec-rails, which was broken due to our fixed minitest integration.

Bugfixes

  • SimpleCov will run again correctly when used with rspec-rails. The excellent bug report #873 by @odlp perfectly details what went wrong. Thanks to @adam12 for the fix #874.

v0.18.3

Small bugfix release. It's especially recommended to upgrade simplecov-html as well because of bugs in the 0.12.0 release.

Bugfixes

  • Fix a regression related to file encodings as special characters were missing. Furthermore we now respect the magic # encoding: ... comment and read files in the right encoding. Thanks (@Tietew) - see #866
  • Use Minitest.after_run hook to trigger post-run hooks if Minitest is present. See #756 and #855 thanks (@adam12)

v0.18.2

Small release just to allow you to use the new simplecov-html.

Enhancements

  • Relax simplecov-html requirement so that you're able to use 0.12.0

v0.18.1

Small Bugfix release.

Bugfixes

  • Just putting # :nocov: on top of a file or having an uneven number of them in general works again and acts as if ignoring until the end of the file. See #846 and thanks @DannyBen for the report.

v0.18.0

Huge release! Highlights are support for branch coverage (Ruby 2.5+) and dropping support for EOL'ed Ruby versions (< 2.4). Please also read the other beta patch notes.

Enhancements

  • You can now define the minimum expected coverage by criterion like minimum_coverage line: 90, branch: 80
  • Memoized some internal data structures that didn't change to reduce SimpleCov overhead
  • Both FileList and SourceFile now have a coverage method that returns a hash that points from a coverage criterion to a CoverageStatistics object for uniform access to overall coverage statistics for both line and branch coverage

Bugfixes

  • we were losing precision by rounding the covered strength early, that has been removed. For Formatters this also means that you may need to round it yourself now.
  • Removed an inconsistency in how we treat skipped vs. irrelevant lines (see #565) - SimpleCov's definition of 100% is now "You covered everything that you could" so if coverage is 0/0 that's counted as a 100% no matter if the lines were irrelevant or ignored/skipped

Noteworthy

  • FileList stopped inheriting from Array, it includes Enumerable so if you didn't use Array specific methods on it in formatters you should be fine

v0.18.0.beta3

Enhancements

... (truncated)
Changelog

Sourced from simplecov's changelog.

0.18.5 (2020-02-25)

Can you guess? Another bugfix release!

Bugfixes

  • minitest won't crash if SimpleCov isn't loaded - aka don't execute SimpleCov code in the minitest plugin if SimpleCov isn't loaded. Thanks to @edariedl for the report of the peculiar problem in #877.

0.18.4 (2020-02-24)

Another small bugfix release 🙈 Fixes SimpleCov running with rspec-rails, which was broken due to our fixed minitest integration.

Bugfixes

  • SimpleCov will run again correctly when used with rspec-rails. The excellent bug report #873 by @odlp perfectly details what went wrong. Thanks to @adam12 for the fix #874.

0.18.3 (2020-02-23)

Small bugfix release. It's especially recommended to upgrade simplecov-html as well because of bugs in the 0.12.0 release.

Bugfixes

  • Fix a regression related to file encodings as special characters were missing. Furthermore we now respect the magic # encoding: ... comment and read files in the right encoding. Thanks (@Tietew) - see #866
  • Use Minitest.after_run hook to trigger post-run hooks if Minitest is present. See #756 and #855 thanks (@adam12)

0.18.2 (2020-02-12)

Small release just to allow you to use the new simplecov-html.

Enhancements

  • Relax simplecov-html requirement so that you're able to use 0.12.0

0.18.1 (2020-01-31)

Small Bugfix release.

Bugfixes

  • Just putting # :nocov: on top of a file or having an uneven number of them in general works again and acts as if ignoring until the end of the file. See #846 and thanks @DannyBen for the report.

0.18.0 (2020-01-28)

Huge release! Highlights are support for branch coverage (Ruby 2.5+) and dropping support for EOL'ed Ruby versions (< 2.4). Please also read the other beta patch notes.

You can run with branch coverage by putting enable_coverage :branch into your SimpleCov configuration (like the SimpleCov.start do .. end block)

... (truncated)
Commits
  • 12ddf6a Prep 0.18.5 release
  • 06225b5 Only run our minitest plugin code if SimpleCov is indeed defined
  • dfada04 make changelog message less... recommended ;)
  • 5652750 Remove lots of unneeded rails files/stuff
  • ac5f6ee give github actions sqlite3 for hopefully a good install
  • a459bcb prep 0.18.4 release
  • d12076c add not about our rails projects
  • 8257bd6 fix JRuby on Rails
  • 871bbb5 Skip Rails 6 with ruby < 2.5 and give bundler more time
  • e408619 Always define SimpleCov.external_at_exit
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Jun 8, 2020
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/simplecov-eq-0.18.5 branch from d7da162 to 36fe130 Compare June 8, 2020 06:50
@koic
Copy link
Member

koic commented Jun 8, 2020

@dependabot rebase.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/simplecov-eq-0.18.5 branch from 36fe130 to f35629e Compare June 8, 2020 15:29
koic added a commit to koic/faker that referenced this pull request Jun 8, 2020
Closes faker-ruby#2043.

This PR fixes the following build error when using cc-test-reporter with
SimpleCov 0.18.

```console
Run export GIT_BRANCH="${GITHUB_REF/refs\/heads\//}"
Error: json: cannot unmarshal object into Go struct field input.coverage
of type []formatters.NullInt
Usage:
  cc-test-reporter after-build [flags]

(snip)

Global Flags:
  -d, --debug   run in debug mode

##[error]Process completed with exit code 255.
```

https://github.com/faker-ruby/faker/pull/2043/checks?check_run_id=750522010

This patch is a workaround until the following issue will be resolved.
codeclimate/test-reporter#418
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/simplecov-eq-0.18.5 branch from f35629e to c1a761e Compare June 10, 2020 11:32
@Zeragamba
Copy link
Contributor

@dependabot rebase

@dependabot-preview
Copy link
Contributor Author

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

koic added a commit to koic/faker that referenced this pull request Jun 11, 2020
Closes faker-ruby#2043.

This PR fixes the following build error when using cc-test-reporter with
SimpleCov 0.18.

```console
Run export GIT_BRANCH="${GITHUB_REF/refs\/heads\//}"
Error: json: cannot unmarshal object into Go struct field input.coverage
of type []formatters.NullInt
Usage:
  cc-test-reporter after-build [flags]

(snip)

Global Flags:
  -d, --debug   run in debug mode

##[error]Process completed with exit code 255.
```

https://github.com/faker-ruby/faker/pull/2043/checks?check_run_id=750522010

This patch is a workaround until the following issue will be resolved.
codeclimate/test-reporter#418
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/simplecov-eq-0.18.5 branch from c1a761e to 5ae39fe Compare June 23, 2020 06:48
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/simplecov-eq-0.18.5 branch from 5ae39fe to b2d5c99 Compare July 7, 2020 06:34
koic added a commit to koic/faker that referenced this pull request Jul 7, 2020
Closes faker-ruby#2043.

This PR fixes the following build error when using cc-test-reporter with
SimpleCov 0.18.

```console
Run export GIT_BRANCH="${GITHUB_REF/refs\/heads\//}"
Error: json: cannot unmarshal object into Go struct field input.coverage
of type []formatters.NullInt
Usage:
  cc-test-reporter after-build [flags]

(snip)

Global Flags:
  -d, --debug   run in debug mode

##[error]Process completed with exit code 255.
```

https://github.com/faker-ruby/faker/pull/2043/checks?check_run_id=750522010

This patch is a workaround until the following issue will be resolved.
codeclimate/test-reporter#418
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/simplecov-eq-0.18.5 branch from b2d5c99 to b1153a3 Compare July 8, 2020 06:41
koic added a commit to koic/faker that referenced this pull request Jul 8, 2020
Closes faker-ruby#2043.

This PR fixes the following build error when using cc-test-reporter with
SimpleCov 0.18.

```console
Run export GIT_BRANCH="${GITHUB_REF/refs\/heads\//}"
Error: json: cannot unmarshal object into Go struct field input.coverage
of type []formatters.NullInt
Usage:
  cc-test-reporter after-build [flags]

(snip)

Global Flags:
  -d, --debug   run in debug mode

##[error]Process completed with exit code 255.
```

https://github.com/faker-ruby/faker/pull/2043/checks?check_run_id=750522010

This patch is a workaround until the following issue will be resolved.
codeclimate/test-reporter#418
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/simplecov-eq-0.18.5 branch from b1153a3 to 6e870d2 Compare July 14, 2020 06:36
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/simplecov-eq-0.18.5 branch from 6e870d2 to 9145215 Compare August 11, 2020 00:22
Updates the requirements on [simplecov](https://github.com/colszowka/simplecov) to permit the latest version.
- [Release notes](https://github.com/colszowka/simplecov/releases)
- [Changelog](https://github.com/colszowka/simplecov/blob/master/CHANGELOG.md)
- [Commits](simplecov-ruby/simplecov@v0.17.1...v0.18.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/simplecov-eq-0.18.5 branch from 9145215 to 860552f Compare August 13, 2020 13:12
@dependabot-preview
Copy link
Contributor Author

Superseded by #2110.

@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/simplecov-eq-0.18.5 branch August 17, 2020 06:42
koic added a commit to koic/faker that referenced this pull request Mar 1, 2021
Closes faker-ruby#2043.

This PR fixes the following build error when using cc-test-reporter with
SimpleCov 0.18.

```console
Run export GIT_BRANCH="${GITHUB_REF/refs\/heads\//}"
Error: json: cannot unmarshal object into Go struct field input.coverage
of type []formatters.NullInt
Usage:
  cc-test-reporter after-build [flags]

(snip)

Global Flags:
  -d, --debug   run in debug mode

##[error]Process completed with exit code 255.
```

https://github.com/faker-ruby/faker/pull/2043/checks?check_run_id=750522010

This patch is a workaround until the following issue will be resolved.
codeclimate/test-reporter#418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants