Skip to content

v3.43.1: GitHub Action fix for Linux runners, and fewer false positives

Latest

Choose a tag to compare

@BartWaardenburg BartWaardenburg released this 14 Nov 21:41
· 6 commits to main since this release
Immutable release. Only release title and notes can be modified.
v3.43.1
8cc305d

Upgrade notes

  • If your workflow uses the fallow GitHub Action on a Linux runner, this release repairs it. With fallow 3.43.0, the install step of the Action failed on glibc runners such as ubuntu-latest. No change to your workflow is necessary: fallow-rs/fallow@v3 now gets the fix. If you set the input version: 3.42.0 as a workaround, you can remove it.

Changed

  • The fallow skill says what to do when the installed CLI is older than the skill. A plugin can deliver a newer skill than the installed CLI. An unexpected argument error, an invalid value error, or an unknown subcommand then means a version difference. The skill tells the agent to report the version, to tell you to update, and to continue without the argument. (fallow-skills#235)

Bug fixes

  • The GitHub Action no longer fails its install step on a glibc Linux runner. Since 3.43.0, npm installs only the platform package for the libc of the host. The Action then looked for the musl package on a glibc host and stopped with platform package @fallow-cli/linux-x64-musl not installed. The Action now finds the installed package. (#4591)

  • includeEntryExports no longer reports the React Router and Remix entry.server exports as unused. The exports default, handleDataRequest, handleError and streamTimeout now count as used. For React Router, instrumentations and unstable_instrumentations also count as used. A custom appDirectory gets the same rule. Thanks @cr101 for the report. (#4583)

  • Entry-point named re-exports through export * barrels credit the underlying declaration. fallow dead-code reported a type or value as unused when an entry file re-exported it by name from an export * barrel. Each namespace of a merged declaration, type and value, now gets its own credit. Thanks @mattlewis92 for the report. (#4579)

  • fallow audit no longer reports an old clone group as introduced when the change rewrites the lines above one copy. A rename of one copy, together with fewer import lines above the other copy, could fail --gate new-only on duplication that the change did not write. (#4580)

  • VS Code: the "enable" links in the Security Candidates and Health views no longer freeze Settings in Cursor. The links now run the new Fallow: Enable Security Candidates and Fallow: Enable Health View commands. These commands set fallow.security.enabled or fallow.health.enabled in workspace settings, or in user settings when no folder is open. Thanks @milichev for the report. (#4553)

  • fallow migrate keeps the production markers of a migrated config visible. An ignoreDependencies or ignoreBinaries name such as left-pad! now migrates as left-pad, with a warning. A project exclusion with the production marker gets a warning with an overrides entry that hides the paths. A plugin section whose config names files that the plugin does not find by name now gets a warning that names these files. Thanks @cr101 for the report. (#4585)

  • The Playwright plugin reads configs with other names. A config named playwright.<name>.config.<ext>, such as playwright.e2e.config.ts, is now a Playwright config. So is a config that a package.json script passes with playwright test --config <file> or -c <file>. The plugin also reads .mts, .mjs, .cts and .cjs configs. A script that runs a tool by its path, such as node_modules/.bin/playwright, now also gives its --config file to the plugin. Thanks @cr101 for the report. (#4586)

  • unlisted-binaries no longer reports shell reserved words or subshell parentheses as binaries. A script with for ... do ... done or if ... then ... fi gave findings such as for, do and fi. A script with a subshell gave findings such as (tool. The script parser now skips reserved words, reads a subshell as a separate command, and finds the command after a case pattern and in a function body. Thanks @ethan-huo for the report. (#4566)

  • A JSDoc visibility tag on a re-export now stops the unused report. Fallow now reads @public, @internal, @beta, @alpha and @expected-unused on export { a, b } from './impl', on export * as ns from './impl', and on export { a, b } that forwards imported bindings. A re-export with a visibility tag is public API and counts as a use of its source export. The cache versions change, so the first run after the update parses every file again. Thanks @cr101 for the report. (#4584)

  • --constant-parameters follows a loader helper that returns a value loaded from an unknown source. A module-scope function such as export const load = (path) => import(path) is now a loader. So const mod = await load(name); mod.migrate() skips only the exported functions named migrate, and the rule keeps its other findings. (#4567)

  • fallow dead-code credits a member on a local that holds a method call result. In const rotated = local.rotate(angle); rotated.translate(1, 1);, fallow now credits Point.translate, as it does for the chained call. Thanks @Smrtnyk for the report. (#4552)

Full Changelog: v3.43.0...v3.43.1