Skip to content

Conversation

SkeLLLa
Copy link
Contributor

@SkeLLLa SkeLLLa commented May 18, 2020

Better options handling. Usually most configuration objects are frozen, so it adds slightly better experience for using it with other modules and better for debugging.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, do you need this backported to the fastify v2 line as well?

@SkeLLLa
Copy link
Contributor Author

SkeLLLa commented May 18, 2020

@mcollina we can, but spread was introduced without flags in node 8.3.0 (as far as I remember). And for fastify v2 there were tests for node 6.

Basically I've added this, because old node versions were removed from tests.

@jsumners
Copy link
Member

A back port can be accomplished with Object.assign. It is effectively equivalent in this case.

@mcollina mcollina merged commit d34145e into fastify:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants