Skip to content

fix: don't modify options #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2020
Merged

fix: don't modify options #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,7 @@ const fp = require('fastify-plugin')
const Redis = require('ioredis')

function fastifyRedis (fastify, options, next) {
const namespace = options.namespace
delete options.namespace
let redisUrl
if (options.url) {
redisUrl = options.url
delete options.url
}
const { namespace, url, ...redisOptions } = options

let client = options.client || null

Expand All @@ -29,10 +23,10 @@ function fastifyRedis (fastify, options, next) {

if (!client) {
try {
if (redisUrl) {
client = new Redis(redisUrl, options)
if (url) {
client = new Redis(url, redisOptions)
} else {
client = new Redis(options)
client = new Redis(redisOptions)
}
} catch (err) {
return next(err)
Expand All @@ -48,10 +42,10 @@ function fastifyRedis (fastify, options, next) {
} else {
if (!client) {
try {
if (redisUrl) {
client = new Redis(redisUrl, options)
if (url) {
client = new Redis(url, redisOptions)
} else {
client = new Redis(options)
client = new Redis(redisOptions)
}
} catch (err) {
return next(err)
Expand Down