Make include_simulator_logs only copy simulator logs if tests fail

[Brett-Best]

We have a long test run ~60mins with the simulator open, this is used to identify flakey tests.

After they pass, the collection of simulator logs can take 20-30mins and results in a several GB file which we discard anyway.

It would be beneficial to add a configuration or change this from a bool to a configuration so it can be configured e.g. to be always and on-failure.

Currently this is handled

fastlane/scan/lib/scan/runner.rb

Line 263 in 8e08a6a

copy_simulator_logs

and just below this the results are available so we could rejig this function fairly easy.

[iBotPeaches]

Yeah I think a setting for that could be fine. Not sure the purpose of the logs anyway outside of debugging