Set the SHARE env variable only if current branch is main #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielj
changed the title
arielj
changed the title
arielj
changed the title
arielj
force-pushed
the
feature/share-on-main
branch
from
3a6bc05 to
aa4e792
Compare
arielj
changed the title
rishijain
approved these changes
Oct 11, 2022
|
the changes lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the setup of the workflow to only set the
SHAREenv variable if the current branch is main.I have no way of testing this completely until is merged into main.
I first tried to set either
1or an empty string to the SHARE variable but it didn't work (bechmarks.ips only checks if the env variable is set, not the value, so an empty var triggers the sharing too).Instead, I went with the solution from the docs here https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#environment-files, making the step that sets the env variable conditional to the branch name.
Fixes #207