Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle report json #61

Merged
merged 12 commits into from Oct 27, 2022
Merged

Bundle report json #61

merged 12 commits into from Oct 27, 2022

Conversation

rishijain
Copy link
Collaborator

Description:
Closes #34

This PR is built on top of the work done in #35 by @boscomonkey.

boscomonkey and others added 8 commits July 27, 2022 12:46
@boscomonkey @rishijain
#34: added spec for bundle_report outdated to allow future refactoring
c7013aa
@boscomonkey @rishijain
#34: refactored STDOUT output portion of `NextRails::BundleReport.out…
b343754 
…dated` into separate class method

In preparation for add `output_to_json` method that can be called conditionally.

Passes spec written in previous commit.
@boscomonkey @rishijain
#34: fix stoopid copy pasta typo
90c0afe
@boscomonkey @rishijain
#34: added boolean argument to NextRails::BundleReport.outdated to …
90e7d2c 
…conditionally output JSON

Added test-first spec to prevent regression.
@boscomonkey @rishijain
#34: connected CLI option parsing to NextRails::BundleReport.outdated
0808689 
Also inverted boolean arg to make the conditionally easier to reason (no double negatives).
@boscomonkey @rishijain
#34: last minor text changes before PR
ff81b23
@boscomonkey @rishijain
#34: linking to the correct PR URL. Dooh!
8bad8af
@rishijain
updated as per review and spec
8845b13
@rishijain rishijain requested a review from a team as a code owner July 27, 2022 08:40
@rishijain rishijain requested review from bronzdoc and kindoflew and removed request for a team July 27, 2022 08:40
@mateusdeap mateusdeap requested review from hmdros and kaysiz and removed request for bronzdoc and kindoflew September 27, 2022 01:38
@mateusdeap
Copy link
Member

@kaysiz @hmdros Tagging you both for this one as well, at your leisure.

etagwerker
etagwerker approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishijain Looks good, thank you!

@etagwerker etagwerker merged commit 5f44ff2 into main Oct 27, 2022
@etagwerker etagwerker deleted the bundle_report_json branch October 27, 2022 12:29
@etagwerker etagwerker mentioned this pull request Oct 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etagwerker etagwerker etagwerker approved these changes

@hmdros hmdros Awaiting requested review from hmdros

@kaysiz kaysiz Awaiting requested review from kaysiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] bundle_report outdated outputs in JSON format when passed optional argument
4 participants
@rishijain @mateusdeap @etagwerker @boscomonkey