Skip to content

Conversation

grzegorz-jakubiak
Copy link
Contributor

As in title I replaced map.inject and/or map.sum with sum

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files          19       19           
  Lines         296      296           
=======================================
  Hits          242      242           
  Misses         54       54
Impacted Files Coverage Δ
...ib/skunk/rubycritic/analysed_modules_collection.rb 87.5% <100%> (ø) ⬆️
lib/skunk/cli/commands/status_reporter.rb 97.56% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 292b7c0...ebc4c09. Read the comment docs.

Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grzegorz-jakubiak I think this is a good idea. The only problem is that Array#sum was introduced in Ruby 2.4, so it might make skunk not work with Ruby < 2.3 versions.

@etagwerker etagwerker merged commit 95ac0e0 into fastruby:master Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants