Skip to content

Use sum directly #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2020
Merged

Use sum directly #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/skunk/cli/commands/status_reporter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ def sorted_modules
end

def total_stink_score
@total_stink_score ||= non_test_modules.map(&:stink_score).inject(0.0, :+)
@total_stink_score ||= non_test_modules.sum(&:stink_score)
end

def total_churn_times_cost
non_test_modules.map(&:churn_times_cost).sum
non_test_modules.sum(&:churn_times_cost)
end

def stink_score_average
Expand Down
2 changes: 1 addition & 1 deletion lib/skunk/rubycritic/analysed_modules_collection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ class AnalysedModulesCollection
def stink_score_average
num_modules = @modules.size
if num_modules.positive?
map(&:stink_score).reduce(:+) / num_modules.to_f
sum(&:stink_score) / num_modules.to_f
else
0.0
end
Expand Down