Skip to content

Conversation

etagwerker
Copy link
Member

Hey,

This PR adds a line to the end of the status reporter.

This way it will be easier to know what version someone used to generate their skunk report:

Screen Shot 2020-04-05 at 1 38 46 PM

Please check it out.

Thanks!

This will help in debugging any failures in real world usage
We want to make sure that the status reporter includes a version number for the Skunk library they were using
This helps in running and debugging individual tests. If we don't do this, we get an error about `def stink_score` being undefined.
@codecov
Copy link

codecov bot commented Apr 5, 2020

Codecov Report

Merging #37 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   81.75%   81.81%   +0.06%     
==========================================
  Files          19       19              
  Lines         296      297       +1     
==========================================
+ Hits          242      243       +1     
  Misses         54       54              
Impacted Files Coverage Δ
lib/skunk/cli/commands/status_reporter.rb 97.56% <ø> (ø)
...est/lib/skunk/cli/commands/status_reporter_test.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc1665...6d34d01. Read the comment docs.

@etagwerker etagwerker merged commit 055cee0 into master Apr 5, 2020
@etagwerker etagwerker deleted the feature/status-output-version-number branch April 5, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant