Skip to content

Feature/status output version number #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2020
Merged

Feature/status output version number #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82c0e47
Add a footer note to display Skunk's version
etagwerker Apr 5, 2020
014cd00
Make sure that we test new behavior
etagwerker Apr 5, 2020
6d34d01
Make sure that we load skunk's analysed_module before testing anything
etagwerker Apr 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/skunk/cli/commands/status_reporter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ class StatusReporter < RubyCritic::Command::StatusReporter
Modules Analysed: <%= analysed_modules_count %>
StinkScore Average: <%= stink_score_average %>
<% if worst %>Worst StinkScore: <%= worst.stink_score %> (<%= worst.pathname %>)<% end %>

Generated with Skunk v<%= Skunk::VERSION %>
TEMPL
)

Expand Down
3 changes: 2 additions & 1 deletion test/lib/skunk/cli/commands/status_reporter_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ def analysed_module.churn
end

it "reports the StinkScore" do
_(reporter.update_status_message).must_equal output
_(reporter.update_status_message).must_include output
_(reporter.update_status_message).must_include "Generated with Skunk v#{Skunk::VERSION}"
end
end
end
Expand Down
1 change: 1 addition & 0 deletions test/test_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
require "minitest/autorun"
require "minitest/pride"
require "minitest/around/spec"
require "skunk/rubycritic/analysed_module"

def context(*args, &block)
describe(*args, &block)
Expand Down