Add minimum required ruby version for this gem #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=======================================
Coverage 81.93% 81.93%
=======================================
Files 19 19
Lines 299 299
=======================================
Hits 245 245
Misses 54 54 Continue to review full report at Codecov.
|
bronzdoc
reviewed
Apr 5, 2020
skunk.gemspec
Outdated
| spec.description = "Knows how to calculate the StinkScore for a Ruby file" | ||
| spec.homepage = "https://github.com/fastruby/skunk" | ||
|
|
||
| spec.required_ruby_version = ">= 2.5.0" |
There was a problem hiding this comment.
Does the test suite breaks using 2.0.0?
There was a problem hiding this comment.
@etagwerker I think the highest we should support is ruby >= 2.4. I updated #39
etagwerker
force-pushed
the
fixes/required-ruby-version
branch
from
5f42de9 to
1f4aea4
Compare
Merged
bronzdoc
reviewed
Apr 7, 2020
.rubocop_todo.yml
Outdated
| Exclude: | ||
| - 'lib/skunk/cli/commands/status_reporter.rb' | ||
|
|
||
| Layout/IndentHeredoc: |
There was a problem hiding this comment.
@bronzdoc If I delete it Rubocop complains a code style violation. I've followed their suggestion and renamed it as Layout/HeredocIndentation
etagwerker
force-pushed
the
fixes/required-ruby-version
branch
from
1f4aea4 to
7895e10
Compare
bronzdoc
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This PR fixes #35.
Please check it out.
Thanks!