Skip to content

Conversation

etagwerker
Copy link
Member

@etagwerker etagwerker commented Apr 5, 2020

This is just an idea suggested by @bronzdoc. Does skunk work with Ruby >= 2.0 and < 2.5?

@etagwerker
Copy link
Member Author

@bronzdoc It seems that supporting Ruby 2.4 or below is not trivial. For example: https://travis-ci.org/github/fastruby/skunk/jobs/671368358

@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #39 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   81.81%   81.93%   +0.12%     
==========================================
  Files          19       19              
  Lines         297      299       +2     
==========================================
+ Hits          243      245       +2     
  Misses         54       54              
Impacted Files Coverage Δ
lib/skunk.rb 100.00% <ø> (ø)
lib/skunk/cli/commands/compare.rb 86.36% <100.00%> (ø)
lib/skunk/cli/commands/status_reporter.rb 97.67% <100.00%> (+0.11%) ⬆️
lib/skunk/rubycritic/analysed_module.rb 100.00% <100.00%> (ø)
...ib/skunk/rubycritic/analysed_modules_collection.rb 87.50% <100.00%> (ø)
test/lib/skunk/cli/commands/compare_test.rb 100.00% <100.00%> (ø)
...est/lib/skunk/cli/commands/status_reporter_test.rb 100.00% <100.00%> (ø)
test/lib/skunk/rubycritic/analysed_module_test.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 055cee0...2d095de. Read the comment docs.

@bronzdoc
Copy link
Contributor

bronzdoc commented Apr 6, 2020

@etagwerker it seems that rubycritic is droping support for ruby 2.3 and below, so we probably should do the same.

For ruby 2.4 there is a bug in sexp_processor 4.14.0 that is fixed in 4.14.1

@etagwerker etagwerker force-pushed the feature/support-older-rubies branch from 556582b to 52b1b60 Compare April 7, 2020 12:42
@etagwerker etagwerker merged commit e7742fc into master Apr 7, 2020
@etagwerker etagwerker deleted the feature/support-older-rubies branch April 7, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants