Issue 3: fixing attempt #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on Windows, looks like fixed
spawn.js
Outdated
There was a problem hiding this comment.
Unfortunatelly, it won't be compatible with Node (link). I think that's bug rather than a feature, but it would be better to clarify. I've already created an issue for that (nodejs/node-v0.x-archive#7138) and got no answer.
What about adding a link to this issue in comments?
|
@joshski as nodejs/node-v0.x-archive#7138 is now closed, I've added proper handling for empty arguments (together with test). Would you mind taking a look and merging it? I close #7, because it's a strict subset of this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #7 - I've added one more specific test and arguments escaping.