Repository navigation
BotKit security updates: 0.4.12 and 0.5.9 #64
dahlia
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
If you use BotKit 0.4.0–0.4.11 or 0.5.0–0.5.8, update to a patched release now. These releases shipped with Fedify versions affected by missing deadlines in WebFinger lookups (GHSA-9pmv-w936-hj3f), outbound activity delivery (GHSA-fq5h-gjhp-g75x), and NodeInfo lookups (GHSA-64hq-2hgr-q4pm), as well as an origin-check bypass for embedded objects (GHSA-r388-57j3-5fgp).
GHSA-9pmv-w936-hj3f can stall a lookup when your bot resolves a handle on a slow remote server. Inbox processing can also reach WebFinger when Fedify falls back to it while re-fetching an incoming activity. The fix gives each WebFinger lookup a single 10-second deadline, including redirects. Non-portable actor handle resolution shares that budget across the initial lookup and alias checks.
GHSA-fq5h-gjhp-g75x lets a slow remote inbox hold delivery workers and connections open, potentially delaying deliveries to other servers. The fix gives each signed or unsigned delivery attempt a single 30-second deadline, including redirects and signature retries. Timed-out attempts can be retried under your configured delivery schedule.
GHSA-64hq-2hgr-q4pm affects applications that explicitly query NodeInfo on remote servers. A slow server can stall the lookup; ordinary inbound federation does not trigger it. The fix gives the entire lookup a 10-second deadline by default and stops following redirects when a URL repeats.
GHSA-r388-57j3-5fgp affects how Fedify reads embedded objects from remote JSON-LD. A remote actor could send a signed activity that caused a BotKit handler to receive forged content under another server's object ID. The fix applies the embedded object's origin check even when its parent has no
id.Fedify 2.3.16 also fixes two issues in
@fedify/backfill, which BotKit does not use. If your application uses that package separately, upgrade it too. GHSA-x58x-xx7h-7rh4 allowed backfill to return forged embedded content under another server's ID; the fix fetches cross-origin objects by ID instead of trusting the embedded copy. GHSA-h3jv-px69-2gpj affected custom loaders that did not validate the origin of returned IDs; the fix rejects results whose ID origin differs from the requested origin, even after a cross-origin redirect. See Fedify's own announcement for backfill upgrade guidance.The first patched BotKit releases, and the versions we recommend installing, are 0.4.12 and 0.5.9. They require Fedify 2.1.32 and 2.3.16, respectively. These are the two supported BotKit lines under the security policy. If you're on an older line, move to a supported release.
For BotKit 0.5.x, install
@fedify/botkit0.5.9 using the command for your package manager:For BotKit 0.4.x, install
@fedify/botkit0.4.12:Check your installed versions or lockfile for older copies of
@fedify/fedify,@fedify/vocab, and@fedify/webfinger. The patched versions start at 2.1.32 on the 2.1.x line and 2.3.16 on the 2.3.x line. If you depend on these packages directly, update those dependencies too. If your dependency constraints prevent an upgrade, change them explicitly. After updating, redeploy all web and worker processes.Thanks to zx (@manus-pi) for reporting the WebFinger, delivery, and NodeInfo issues to Fedify, and to @manus-use for reporting the WebFinger and NodeInfo issues. Thanks also to @dahlia for reporting the embedded-object origin-check bypass and the cross-origin backfill issue, and to @sij411 for reporting the custom backfill loader issue.
If anything is unclear, feel free to ask on GitHub Discussions or Matrix.
All reactions