Repository navigation
Fedify security updates: 2.0.36, 2.1.32, 2.2.21, 2.3.16, and 2.4.6 #1450
sij411
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
If you use an affected Fedify release, update now. Six vulnerabilities have been fixed: an embedded-object origin-check bypass (GHSA-r388-57j3-5fgp), two content-spoofing issues in backfill (GHSA-x58x-xx7h-7rh4 and GHSA-h3jv-px69-2gpj), and missing deadlines in WebFinger lookups (GHSA-9pmv-w936-hj3f), outbound activity delivery (GHSA-fq5h-gjhp-g75x), and NodeInfo lookups (GHSA-64hq-2hgr-q4pm).
We recommend 2.4.6, or 2.3.16 if you are staying on 2.3. Both releases contain all six fixes. The security policy covers the latest two minor lines, currently 2.3 and 2.4. Backports for the four issues outside
@fedify/backfillare available in 2.0.36, 2.1.32, and 2.2.21. If you rely on one of those backports, plan to move to a supported line. If you are running an affected 1.x release, change your dependency to a supported 2.x release.Embedded-object origin-check bypass (GHSA-r388-57j3-5fgp, medium, CVSS 3.1 score 5.3)
When reading remote JSON-LD, a vocabulary accessor could skip the origin check on an embedded object whose parent has no
id. Inbox listeners, backfill, and applications that read embedded objects directly can receive forged content and store or display it under another server's ID. A valid signature on an incoming activity does not establish ownership of an embedded object's ID. The fix applies the origin check even when the parent lacks anid.This affects
@fedify/fedify,@fedify/vocab, and code generated by@fedify/vocab-toolsbefore the patched release on each of the 2.0–2.4 lines. It also affects the vocabulary bundled with Fedify 1.9 and 1.10. No 1.x patch is planned, and older releases that lack the origin check are not a safe downgrade. If you cannot update immediately, uselookupObject()under the default origin policy to fetch embedded or backfilled objects by ID before storing or displaying them, and use only the fetched copy.Backfill trusted cross-origin embedded content (GHSA-x58x-xx7h-7rh4, high, CVSS 3.1 score 7.5)
Backfill could return embedded content that falsely claimed to come from another server. An application that stores backfill results by ID could overwrite genuine content or poison its cache. The fix restores the default vocabulary origin policy, which can require additional fetches. Backfill results are still unverified remote data; checking the origin does not prove authorship.
Backfill accepted forged IDs from custom loaders (GHSA-h3jv-px69-2gpj, high, CVSS 3.1 score 7.5)
Applications using a custom
BackfillDocumentLoaderwere exposed if the loader did not check the returned object's ID against the origin it fetched from. Backfill could then ingest a forged collection or post under another server's ID. The fix rejects results whose ID origin differs from the requested IRI's origin. That can also exclude legitimate cross-origin redirects.Both backfill issues affect
@fedify/backfillbefore 2.3.16 on the 2.3 line and before 2.4.6 on the 2.4 line. Upgrade@fedify/backfilland make sure it resolves the matching patched@fedify/vocab; the backfill update alone does not fix the vocabulary issue. If you supply a custom loader, follow the backfill documentation: uselookupObject()with the default origin policy and setdocumentUrlto the final response URL in your JSON-LD loader.WebFinger lookups could stall without a deadline (GHSA-9pmv-w936-hj3f, high, CVSS 3.1 score 7.5)
When an application resolves a handle from an untrusted source, a slow remote WebFinger endpoint can tie up the lookup. This can also affect inbox processing when an activity re-fetch falls back to WebFinger.
@fedify/webfingeris affected before the patched release on each of the 2.0–2.4 lines.The fix gives each WebFinger lookup one 10-second deadline, including DNS, redirects, and response reading. Non-portable actor handle resolution shares a 10-second budget across the initial lookup and alias verification. This is not a deadline for all of
lookupObject(): on the 2.0–2.3 lines, the default document loaders still have no deadline of their own. Set a deadline in your document loader or move to 2.4.6 if you need bounded document fetches.Outbound delivery could stall without a deadline (GHSA-fq5h-gjhp-g75x, high, CVSS 3.1 score 7.5)
A slow remote inbox could hold delivery workers and connections open, delaying deliveries to other servers. The advisory confirms the unsigned delivery issue starting in
@fedify/fedify2.0.28. Signed delivery also lacked a deadline, and that behavior predates 2.0.28; the earliest affected signed release has not been established.The patched releases above give each delivery attempt a single 30-second deadline across connection setup, redirects, signature retries, and response reading. If an attempt times out before a final response arrives, it can be retried under the configured delivery schedule.
NodeInfo lookups could stall without a deadline (GHSA-64hq-2hgr-q4pm, medium, CVSS 3.1 score 5.3)
A slow remote server could keep a NodeInfo lookup waiting. This affects applications that explicitly query untrusted server URLs and operators who use
fedify nodeinfoagainst those servers. Inbound federation does not automatically trigger NodeInfo lookups. The issue is confirmed as far back as@fedify/fedify2.0.26; the advisory does not establish when it was introduced. Update@fedify/fedifyand any separately installed@fedify/cli.The fix adds one 10-second default deadline across discovery, redirects, and document fetching. A timeout or cancellation returns
undefinedfrom the API. The API'stimeoutoption is in milliseconds; keep it bounded when querying untrusted servers, sincetimeout: nulldisables the deadline. The CLI's-T/--timeoutoption is in seconds and defaults to 10.Updating
Use the command for your package manager to install 2.4.6:
If you stay on another minor line, substitute the patched version listed above. Update any direct dependencies on
@fedify/vocab,@fedify/webfinger, and@fedify/vocab-runtimeto the matching release, and update@fedify/backfillif you use it. If you generate custom vocabulary classes, update@fedify/vocab-toolsand@fedify/vocab-runtimeto the matching release, then regenerate your classes and rebuild. Check your lockfile for older direct or transitive copies of the affected packages, then redeploy all web and worker processes.For an npm-installed global CLI:
For other installation methods, use the CLI installation instructions and check the installed release with
fedify --version.Thanks to @dahlia for reporting the embedded-object origin-check bypass and the cross-origin backfill issue, and to @sij411 for reporting the custom backfill loader issue. Thanks to zx (@manus-pi) for reporting the WebFinger, delivery, and NodeInfo issues, and to @manus-use for reporting the WebFinger and NodeInfo issues.
If anything is unclear, ask below.
All reactions