This repository has been archived by the owner on May 26, 2018. It is now read-only.
Delay initialization #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's not redirect stdout and stderr, and let's not refresh the menus, unless ImageJ1 has been initialized first.
What we really want is to initialize *after* the LegacyService has initialized. The normal way to accomplish this would be to add an @parameter on the LegacyService, which would force that service to be initialized first. Unfortunately, by doing that, we force the class loader to load the LegacyService prematurely, hosing everything. So the hacky solution we employ here is instead to listen for when context creation is totally complete (signified by the ServicesLoadedEvent being fired), and *then* finally initialize the DefaultFijiService. We do it this way, rather than a lazy initialization scheme, because we *do* want the DefaultFijiService to initialize right away rather than only in response to some API call later.
|
Thanks! We should probably upload a new |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to delay initialization of the
DefaultFijiServiceuntil after theLegacyServicehas initialized (and hence set up ImageJ1 as desired, including patches). But we cannot add a direct dependency onLegacyServicevia the usual@Parametermechanism because that would hose the class loading process. So let's makeDefaultFijiServiceinitialize itself very late in the game.