-
Notifications
You must be signed in to change notification settings - Fork 3.6k
feat: add context menu #3343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add context menu #3343
Conversation
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Bump |
|
Please add 2FA with a TOTP. |
9631dda to
67a280c
Compare
|
I found a bug in the menu implementation. When you click the right button on a file for the second time, the file becomes unselected and then the menu opens for the entire folder. screen.recording.mov |
This was an International feature since originally, a right click would still select/deselect an item on the list. |
I'd say it should select but not unselect a file. Otherwise, it's just confusing and looks buggy |
|
First of all, thank you very much for your contribution. The context menu feature is very helpful to us and is very convenient to use.
If you have any questions, please feel free to contact me. Thank you again for your contribution. Code diff |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Bump, will get to it soon |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Bump |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Bump |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Bump |
|
A lot of work seems to have been put into this. |
67a280c to
3f21a64
Compare
|
@o1egl Finally completed this issue, please let me know if any updates are still required |
|
@ultwcz hope this commit resolves your issues, lmk |
Ok, I will test it. Thank you. |
|
bump |
|
bump |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Bump |
|
@o1egl would be nice to get this merged soon! |
|
@omalk98 I'd recommend reading the current project status when it comes to adding new features: https://github.com/filebrowser/filebrowser#project-status |
Oh, that's a shame. It would have been great to get this merged. |
0373668 to
ab0eec0
Compare
hacdias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I updated the PR and fixed the positioning of the counter. Let's hope it's free of bugs.

New PR for #2871 updated to Vue3
#2871