Skip to content

Conversation

@omalk98
Copy link
Contributor

@omalk98 omalk98 commented Jul 1, 2024

New PR for #2871 updated to Vue3
#2871

@omalk98 omalk98 requested a review from o1egl as a code owner July 1, 2024 07:04
@omalk98 omalk98 changed the title Add context menu: New PR for #2871 feat: Add context menu Jul 1, 2024
@github-actions
Copy link

github-actions bot commented Aug 1, 2024

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 1, 2024
@omalk98
Copy link
Contributor Author

omalk98 commented Aug 1, 2024

Bump

@github-actions github-actions bot removed the Stale label Aug 2, 2024
@vihatsoft
Copy link

Please add 2FA with a TOTP.

@o1egl o1egl force-pushed the add-context-menu branch from 9631dda to 67a280c Compare August 17, 2024 17:17
@o1egl
Copy link
Member

o1egl commented Aug 17, 2024

I found a bug in the menu implementation. When you click the right button on a file for the second time, the file becomes unselected and then the menu opens for the entire folder.

screen.recording.mov

@omalk98
Copy link
Contributor Author

omalk98 commented Aug 20, 2024

I found a bug in the menu implementation. When you click the right button on a file for the second time, the file becomes unselected and then the menu opens for the entire folder.

screen.recording.mov

This was an International feature since originally, a right click would still select/deselect an item on the list.
If this isn't a feature that is preferred to have, I will address it in a commit soon.

@o1egl
Copy link
Member

o1egl commented Aug 21, 2024

I found a bug in the menu implementation. When you click the right button on a file for the second time, the file becomes unselected and then the menu opens for the entire folder.

screen.recording.mov

This was an International feature since originally, a right click would still select/deselect an item on the list. If this isn't a feature that is preferred to have, I will address it in a commit soon.

I'd say it should select but not unselect a file. Otherwise, it's just confusing and looks buggy

@ultwcz
Copy link
Contributor

ultwcz commented Aug 29, 2024

First of all, thank you very much for your contribution. The context menu feature is very helpful to us and is very convenient to use.
I immediately patched my code, but I found several problems during use:

  1. When right-clicking in a blank space, if no file or folder is selected, download and info will appear, and it will conflict with the right-click of the browser;
  2. When switching views, there will be only one column;
  3. The mouse position in the pop-up box that appears when right-clicking is too close, you can move it a little to one side;
  4. When checking the Use single clicks to open files and directories option, the user experience is slightly worse;

If you have any questions, please feel free to contact me. Thank you again for your contribution.

Screenshot
Screenshot 2024-08-29 at 15-59-58 filebrowser - Files - File Browser

Code diff
context_menu.diff.txt

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 29, 2024
@omalk98
Copy link
Contributor Author

omalk98 commented Sep 30, 2024

Bump, will get to it soon

@github-actions github-actions bot removed the Stale label Oct 1, 2024
@github-actions
Copy link

github-actions bot commented Nov 1, 2024

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 1, 2024
@omalk98
Copy link
Contributor Author

omalk98 commented Nov 3, 2024

Bump

@github-actions github-actions bot removed the Stale label Nov 4, 2024
@github-actions
Copy link

github-actions bot commented Dec 4, 2024

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Dec 4, 2024
@omalk98
Copy link
Contributor Author

omalk98 commented Dec 6, 2024

Bump

@github-actions github-actions bot removed the Stale label Dec 7, 2024
@github-actions
Copy link

github-actions bot commented Jan 7, 2025

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jan 7, 2025
@omalk98
Copy link
Contributor Author

omalk98 commented Jan 7, 2025

Bump

@github-actions github-actions bot removed the Stale label Jan 8, 2025
@Mysterius
Copy link

A lot of work seems to have been put into this.

@omalk98
Copy link
Contributor Author

omalk98 commented Feb 27, 2025

@o1egl Finally completed this issue, please let me know if any updates are still required

@omalk98
Copy link
Contributor Author

omalk98 commented Feb 27, 2025

@ultwcz hope this commit resolves your issues, lmk

@ultwcz
Copy link
Contributor

ultwcz commented Feb 27, 2025

@ultwcz hope this commit resolves your issues, lmk

Ok, I will test it.

Thank you.

@domme1908
Copy link

bump

@Vidariondr
Copy link

bump

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 23, 2025
@omalk98
Copy link
Contributor Author

omalk98 commented May 23, 2025

Bump

@github-actions github-actions bot removed the Stale label May 24, 2025
@omalk98
Copy link
Contributor Author

omalk98 commented Aug 2, 2025

@o1egl would be nice to get this merged soon!

@hacdias
Copy link
Member

hacdias commented Aug 3, 2025

@omalk98 I'd recommend reading the current project status when it comes to adding new features: https://github.com/filebrowser/filebrowser#project-status

@albinmedoc
Copy link

@omalk98 I'd recommend reading the current project status when it comes to adding new features: https://github.com/filebrowser/filebrowser#project-status

Oh, that's a shame. It would have been great to get this merged.

@hacdias hacdias requested a review from a team as a code owner November 14, 2025 15:36
@hacdias hacdias changed the title feat: Add context menu feat: add context menu Nov 14, 2025
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I updated the PR and fixed the positioning of the counter. Let's hope it's free of bugs.

@hacdias hacdias merged commit 1ace579 into filebrowser:master Nov 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

9 participants