refactor: use slices.Contains to simplify code (#13076)

There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

Signed-off-by: CoolCu <coolcui@qq.com>

Author: CoolCu

api/miner_subsystems.go

@@ -2,6 +2,7 @@ package api
 
 import (
 	"encoding/json"
+	"slices"
 )
 
 // MinerSubsystem represents a miner subsystem. Int and string values are not
@@ -57,12 +58,7 @@ func (ms *MinerSubsystem) UnmarshalJSON(b []byte) error {
 type MinerSubsystems []MinerSubsystem
 
 func (ms MinerSubsystems) Has(entry MinerSubsystem) bool {
-	for _, v := range ms {
-		if v == entry {
-			return true
-		}
-	}
-	return false
+	return slices.Contains(ms, entry)
 }
 
 func (ms MinerSubsystem) String() string {

build/params_shared_funcs.go

@@ -2,6 +2,7 @@ package build
 
 import (
 	"os"
+	"slices"
 	"strconv"
 	"strings"
 
@@ -107,22 +108,12 @@ func parseF3DisableActivationEnv() (contractAddrs []string, epochs []int64) {
 // epoch number based on environment variable configuration.
 func IsF3EpochActivationDisabled(epoch int64) bool {
 	_, epochs := parseF3DisableActivationEnv()
-	for _, e := range epochs {
-		if e == epoch {
-			return true
-		}
-	}
-	return false
+	return slices.Contains(epochs, epoch)
 }
 
 // IsF3ContractActivationDisabled checks if F3 activation is disabled for the given contract address
 // based on environment variable configuration.
 func IsF3ContractActivationDisabled(contract string) bool {
 	contracts, _ := parseF3DisableActivationEnv()
-	for _, c := range contracts {
-		if c == contract {
-			return true
-		}
-	}
-	return false
+	return slices.Contains(contracts, contract)
 }

chain/events/filter/event.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"math"
+	"slices"
 	"sync"
 	"time"
 
@@ -184,12 +185,7 @@ func (f *eventFilter) matchAddress(o address.Address) bool {
 
 	// Assume short lists of addresses
 	// TODO: binary search for longer lists or restrict list length
-	for _, a := range f.addresses {
-		if a == o {
-			return true
-		}
-	}
-	return false
+	return slices.Contains(f.addresses, o)
 }
 
 func (f *eventFilter) matchKeys(ees []types.EventEntry) bool {

chain/types/tipset.go

@@ -238,12 +238,7 @@ func (ts *TipSet) ParentWeight() BigInt {
 }
 
 func (ts *TipSet) Contains(oc cid.Cid) bool {
-	for _, c := range ts.cids {
-		if c == oc {
-			return true
-		}
-	}
-	return false
+	return slices.Contains(ts.cids, oc)
 }
 
 func (ts *TipSet) IsChildOf(parent *TipSet) bool {

cmd/ci/main.go

@@ -4,6 +4,7 @@ import (
 	"encoding/json"
 	"os"
 	"path/filepath"
+	"slices"
 	"strings"
 
 	log "github.com/sirupsen/logrus"
@@ -247,7 +248,7 @@ func getHasVeryExpensiveTests(testGroupName string) bool {
 	testGroupNames := []string{
 		"itest-niporep_manual",
 	}
-	return contains(testGroupNames, testGroupName)
+	return slices.Contains(testGroupNames, testGroupName)
 }
 
 func getTestGroupMetadata(testGroupName string) TestGroupMetadata {
@@ -327,21 +328,21 @@ func getNeedsParameters(testGroupName string) bool {
 		"unit-cli",
 		"unit-storage",
 	}
-	return contains(testGroupNames, testGroupName)
+	return slices.Contains(testGroupNames, testGroupName)
 }
 
 func getSkipConformance(testGroupName string) bool {
 	testGroupNames := []string{
 		"conformance",
 	}
-	return !contains(testGroupNames, testGroupName)
+	return !slices.Contains(testGroupNames, testGroupName)
 }
 
 func getTestRustProofLogs(testGroupName string) bool {
 	testGroupNames := []string{
 		"multicore-sdr",
 	}
-	return contains(testGroupNames, testGroupName)
+	return slices.Contains(testGroupNames, testGroupName)
 }
 
 func getFormat() string {
@@ -362,12 +363,3 @@ func getGoTestFlags(testGroupName string) string {
 func createPackagePath(pathParts ...string) string {
 	return strings.Join(append([]string{"."}, pathParts...), string(os.PathSeparator))
 }
-
-func contains(slice []string, item string) bool {
-	for _, s := range slice {
-		if s == item {
-			return true
-		}
-	}
-	return false
-}

cmd/release/main.go

@@ -10,6 +10,7 @@ import (
 	"os"
 	"os/exec"
 	"regexp"
+	"slices"
 	"strconv"
 	"strings"
 
@@ -94,12 +95,7 @@ func getBinaries(name string) []string {
 
 func isReleased(tag string) bool {
 	tags := getTags()
-	for _, t := range tags {
-		if t == tag {
-			return true
-		}
-	}
-	return false
+	return slices.Contains(tags, tag)
 }
 
 func getPrefix(name string) string {