Skip to content

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app

Comments
There was a problem with ShowAsync and all Dialogs, it could be easily fixed by moving to TryShowAsync
@Josh-65 could you try this out (I'm not sure if this is the only needed fix)?

@ferrariofilippo
Copy link
Contributor Author

ferrariofilippo commented Sep 26, 2022

Ok, I've just seen that doing literally anything when extracting an archive might crash Files
Edit. This happens very few times

@ferrariofilippo
Copy link
Contributor Author

Testing more, I found out that:

  • This crash does not leave any track: neither in logs nor in debug trace. There are no exceptions still, all threads stop.
  • It seems that crash happens when too many UI events are raised (Decompression alone works fine. There MAY be issues when you start moving/resizing the window, click around, ....)

@Josh65-2201
Copy link
Member

I've notice that Extract here option doesn't work for .zip with the output being the only thing shown. Other two options work fine.

'Files.exe' (Win32): Loaded 'C:\Users\<User>\Downloads\Files-Fixed_Unable_To_Extract_Archives\artifacts\Debug\x64\Files.Package\AppX\7z64.dll'. Module was built without symbols.
'Files.exe' (Win32): Unloaded 'C:\Users\<User>\Downloads\Files-Fixed_Unable_To_Extract_Archives\artifacts\Debug\x64\Files.Package\AppX\7z64.dll'

and they don't show progress or completion in the status centre.

@ferrariofilippo
Copy link
Contributor Author

I tested it again and everythings seems to work. I also recloned the branch for a brand new build and still everything worked.
Please, tell me if it is not working on your build

@Josh65-2201
Copy link
Member

Seems to work now

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Sep 29, 2022
@yaira2 yaira2 merged commit 6ae20d0 into files-community:main Sep 29, 2022
@ferrariofilippo ferrariofilippo deleted the Fixed_Unable_To_Extract_Archives branch October 1, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Unable to extract archives from context menu
4 participants