Skip to content

Fixed: Unable to extract archives from context menu #10070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2022
Merged

Fixed: Unable to extract archives from context menu #10070

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56542e4
Fixed: Unable to extract archives from context menu #10062
ferrariofilippo Sep 26, 2022
72f22cc
Fixed Crash When Extracting Archives
ferrariofilippo Sep 28, 2022
6fc8cea
Error Fixed
ferrariofilippo Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Files.App/Interacts/BaseLayoutCommandImplementationModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,8 +640,7 @@ public async Task DecompressArchive()
DecompressArchiveDialogViewModel decompressArchiveViewModel = new(archive);
decompressArchiveDialog.ViewModel = decompressArchiveViewModel;

ContentDialogResult option = await decompressArchiveDialog.ShowAsync();

ContentDialogResult option = await decompressArchiveDialog.TryShowAsync();
if (option != ContentDialogResult.Primary)
return;

Expand Down Expand Up @@ -707,7 +706,7 @@ private static async Task ExtractArchive(BaseStorageFile archive, BaseStorageFol
Stopwatch sw = new();
sw.Start();

await ZipHelpers.ExtractArchive(archive, destinationFolder, banner.Progress, extractCancellation.Token);
await FilesystemTasks.Wrap(() => ZipHelpers.ExtractArchive(archive, destinationFolder, banner.Progress, extractCancellation.Token));

sw.Stop();
banner.Remove();
Expand Down