Skip to content

Code: Implement inter-process synchronization for LiteDB #10250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 19, 2022
Merged

Code: Implement inter-process synchronization for LiteDB #10250

merged 5 commits into from
Oct 19, 2022

Conversation

hez2010
Copy link
Member

@hez2010 hez2010 commented Oct 19, 2022

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

QuaintMako
QuaintMako reviewed Oct 19, 2022
View reviewed changes
QuaintMako
QuaintMako reviewed Oct 19, 2022
View reviewed changes
QuaintMako
QuaintMako reviewed Oct 19, 2022
View reviewed changes
QuaintMako
QuaintMako reviewed Oct 19, 2022
View reviewed changes
QuaintMako
QuaintMako reviewed Oct 19, 2022
View reviewed changes
QuaintMako
QuaintMako reviewed Oct 19, 2022
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have much experience with threads, but LGTM code-wise aside from the small formatting issues commented above.

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Oct 19, 2022
@yaira2 yaira2 requested a review from QuaintMako October 19, 2022 14:03
@yaira2 yaira2 added needs - code review and removed changes requested Changes are needed for this pull request labels Oct 19, 2022
yaira2
yaira2 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Implement inter-process synchronization for LiteDB Code: Implement inter-process synchronization for LiteDB Oct 19, 2022
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 19, 2022
QuaintMako
QuaintMako approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yaira2 yaira2 merged commit d037223 into main Oct 19, 2022
@hez2010 hez2010 deleted the litedb-refactor branch October 19, 2022 14:33
@gave92 gave92 mentioned this pull request Nov 27, 2022
Merged
1 task
@hez2010 hez2010 mentioned this pull request Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@QuaintMako QuaintMako QuaintMako approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code Quality : Duplication of FileTagHelper
3 participants
@hez2010 @yaira2 @QuaintMako