-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Made some requested changes and fixes for NavigationBar #1500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It is better to create different PR's for each change/fix. |
Since the changes are too small, I thought of bringing them in one pr. Should I close this one and request new prs?? |
Yes, please. |
On second thought most changes are dependent on each other so it won't be possible for me. |
@soumyamahunt I tested the changes and it doesn't look like true support for environment variables was added in the pull request. |
What environment variables did fail?? Some environment variables point to hidden folders hence the navigation will fail. Fixing navigation to hidden folders isn't the focus of my pr. |
Will you add right click to display a list of folders, In the same was as it's possible to tap on the chevron, with the Win32 File Explorer? |
May be in a future pr. |
Added in #1533. |
Made changes requested in #182 and #534. Also, fixed renavigation problems in NavigationBar.