Skip to content

Conversation

soumyamahunt
Copy link
Contributor

Made changes requested in #182 and #534. Also, fixed renavigation problems in NavigationBar.

@ghost ghost added the needs - code review label Jul 18, 2020
@tsvietOK
Copy link
Contributor

It is better to create different PR's for each change/fix.

@soumyamahunt
Copy link
Contributor Author

It is better to create different PR's for each change/fix.

Since the changes are too small, I thought of bringing them in one pr. Should I close this one and request new prs??

@tsvietOK
Copy link
Contributor

It is better to create different PR's for each change/fix.

Since the changes are too small, I thought of bringing them in one pr. Should I close this one and request new prs??

Yes, please.

@soumyamahunt
Copy link
Contributor Author

Yes, please.

On second thought most changes are dependent on each other so it won't be possible for me.

@yaira2 yaira2 requested review from yaira2 and lukeblevins and removed request for yaira2 July 19, 2020 02:10
@yaira2
Copy link
Member

yaira2 commented Jul 19, 2020

@soumyamahunt I tested the changes and it doesn't look like true support for environment variables was added in the pull request.

@soumyamahunt
Copy link
Contributor Author

@soumyamahunt I tested the changes and it doesn't look like true support for environment variables was added in the pull request.

What environment variables did fail?? Some environment variables point to hidden folders hence the navigation will fail. Fixing navigation to hidden folders isn't the focus of my pr.

@files-community files-community deleted a comment from soumyamahunt Jul 19, 2020
@soumyamahunt
Copy link
Contributor Author

Some alternate versions of interaction with navigationbar:

YI8XrEccan.gif

r2HjmT4CjG.gif

@mdtauk
Copy link
Contributor

mdtauk commented Jul 19, 2020

Will you add right click to display a list of folders, In the same was as it's possible to tap on the chevron, with the Win32 File Explorer?

@soumyamahunt
Copy link
Contributor Author

Will you add right click to display a list of folders, In the same was as it's possible to tap on the chevron, with the Win32 File Explorer?

May be in a future pr.

@soumyamahunt
Copy link
Contributor Author

r2HjmT4CjG.gif

This one is the new accepted behavior.

@yaira2 yaira2 merged commit 680ff9b into files-community:master Jul 19, 2020
@soumyamahunt soumyamahunt deleted the navigationbar branch July 19, 2020 17:43
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 19, 2020
@soumyamahunt
Copy link
Contributor Author

Will you add right click to display a list of folders, In the same was as it's possible to tap on the chevron, with the Win32 File Explorer?

Added in #1533.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants