Feature: Added support for displaying background images in folders #15632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
commented
Jun 20, 2024
yaira2
force-pushed
the
ya/CustomFolderImage
branch
from
5e7f3b4 to
4fad4c5
Compare
Revert "Use parser" This reverts commit 4fad4c5. Use parser Update ItemViewModel.cs
yaira2
force-pushed
the
ya/CustomFolderImage
branch
from
7b0f751 to
bf60f11
Compare
|
This PR is ready for review, but won't be merged until after v3.5. |
yaira2
force-pushed
the
ya/CustomFolderImage
branch
3 times, most recently
from
89708b5 to
e07acd4
Compare
|
@hishitetsu I disabled custom backgrounds in Columns View. |
hishitetsu
reviewed
Jun 25, 2024
hishitetsu
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Parsing of INI files needs to be improved, such as considering sections, but that can be addressed in #15654.
LGTM
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.