Skip to content

Code Quality: Remove ini-parser-netstandard dependency #15654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 4, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jun 23, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open Files app
  2. Add a section below
  3. Refresh
[FilesApp]
Files_BackgroundImage=C:\Users\onein\OneDrive\Desktop\Files-Wallpaper-day.png

@0x5bfa 0x5bfa changed the title Code Quality: Added WindowsIniService Code Quality: Remove ini-parser-netstandard dependency Jun 25, 2024
@0x5bfa 0x5bfa marked this pull request as ready for review June 25, 2024 15:56
hishitetsu

This comment was marked as outdated.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I sent a review for another PR. But as I said there, we should consider sections ([...]) when parsing INI files.

@0x5bfa
Copy link
Member Author

0x5bfa commented Jun 26, 2024

How come? The same name in different sections seems not to be supported. We might want, but as of now we don't need to go such far.

@hishitetsu
Copy link
Member

The same name in different sections seems not to be supported.

That should not be the case. In any case, I think we should define a section to avoid affecting other apps.

@yaira2
Copy link
Member

yaira2 commented Jun 26, 2024

Steps used to test these changes

Were these changes tested? I'm trying to test them on my side but it doesn't work.

@0x5bfa
Copy link
Member Author

0x5bfa commented Jun 30, 2024

The same name in different sections seems not to be supported.

That should not be the case. In any case, I think we should define a section to avoid affecting other apps.

@hishitetsu I misunderstood what Wikipedia says and you're right. Now that the PR is ready again.

@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-WindowsINIService branch from f50648a to 5b24ddf Compare June 30, 2024 14:27
yaira2
yaira2 previously approved these changes Jun 30, 2024
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sections seem to work fine.
But background images are displayed even in the columns layout in which they should be disabled.

Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
0x5bfa and others added 5 commits July 3, 2024 00:37
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
@yaira2 yaira2 force-pushed the 5bfa/CQ-WindowsINIService branch from 6f5a956 to 60b7675 Compare July 3, 2024 01:44
Co-authored-by: hishitetsu <66369541+hishitetsu@users.noreply.github.com>
@hishitetsu
Copy link
Member

There seems to be no functional problems. My remaining concern is this. #15654 (comment)

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 3, 2024
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit f596acd into files-community:main Jul 4, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-WindowsINIService branch July 4, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Quality: Remove INI Parser dependency
3 participants