Skip to content

Conversation

seer-by-sentry[bot]
Copy link
Contributor

@seer-by-sentry seer-by-sentry bot commented Oct 5, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Reproduced the issue by triggering a search that would use the SearchResultsFor localized string.
  2. Verified that the application no longer crashes when the localized string contains an invalid format index.
  3. Confirmed that the fallback format is used when the localized string is malformed, and the search header title is displayed correctly.

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Oct 5, 2025
@yaira2 yaira2 marked this pull request as ready for review October 5, 2025 13:42
@yaira2 yaira2 changed the title Fix: Handle malformed localized format strings in search header Code Quality: Handle malformed localized format strings in search header Oct 5, 2025
@yaira2 yaira2 merged commit 4bce02c into main Oct 5, 2025
9 checks passed
@yaira2 yaira2 deleted the seer/fix/malformed-search-header branch October 5, 2025 13:43
@yaira2 yaira2 restored the seer/fix/malformed-search-header branch October 6, 2025 15:01
@yaira2 yaira2 deleted the seer/fix/malformed-search-header branch October 6, 2025 15:01
yaira2 added a commit that referenced this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant