Skip to content

Code Quality: Handle malformed localized format strings in search header #17735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2025
Merged

Code Quality: Handle malformed localized format strings in search header #17735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions src/Files.App/ViewModels/ShellViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2736,9 +2736,25 @@ public async Task SearchAsync(FolderSearch search)
await ApplyFilesAndFoldersChangesAsync();
EmptyTextType = EmptyTextType.None;

SearchHeaderTitle = !string.IsNullOrEmpty(search.Query)
? string.Format(Strings.SearchResultsFor.GetLocalizedResource(), search.Query)
: string.Empty;
if (!string.IsNullOrEmpty(search.Query))
{
try
{
// Try to format the localized string with the search query
SearchHeaderTitle = string.Format(Strings.SearchResultsFor.GetLocalizedResource(), search.Query);
}
catch (FormatException ex)
{
// Handle malformed localized format strings (e.g., incorrect placeholders in translation)
// Fallback to a safe default format
App.Logger.LogWarning(ex, "Malformed localized format string for SearchResultsFor. Using fallback format.");
SearchHeaderTitle = $"Search results for \"{search.Query}\"";
}
}
else
{
SearchHeaderTitle = string.Empty;
}

if (SearchIconBitmapImage is null)
SearchIconBitmapImage ??= await UIHelpers.GetSearchIconResource();
Expand Down
Loading