Fixed an issue with the context menu not appearing when right clicking on exe files #1945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
gave92
changed the title
gave92
force-pushed
the
fix_fulltrustcrash
branch
from
4a67869 to
a539d51
Compare
gave92
force-pushed
the
fix_fulltrustcrash
branch
from
a539d51 to
62228e1
Compare
gave92
changed the title
yaira2
approved these changes
Sep 29, 2020
yaira2
changed the title
yaira2
added
ready to merge
yaira2
changed the title
ChihweiLHBird
pushed a commit
to ChihweiLHBird/files-uwp
that referenced
this pull request
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1944
Issue was due to a memory access error that was for some reason happening when parsing the "Run with graphic processor" context-menu item that appears on PCs with NVidia graphic cards.
This bug was hard to track down because it was happening only on azure release builds: this was because azure builds the Files.Launcher project as x64 while local build uses x86. This PR changes the "Prefer32Bit" option to false in order to have consistent behavior when building locally and on azure. Let me know if it's ok to include this change.