Change windowing/tab behavior when launching Files though different methods #3854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed dependency on args to open new tab instead of instance when launching from start
… a folder in Files"
- Fixed bug where instancing setting was ignored
|
Hmmm, i guess last change (in description) should be reverted, because i pretty often use middle mouse button click to open new instance of any program |
|
@tsvietOK Ok, changes made. |
tsvietOK
approved these changes
Mar 17, 2021
tsvietOK
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3852.
When Files is launched from the command line, the folder will open in a new tab if Files is already open, instead of a new window
Changed "when opening from jumplist" text to "When opening folder in Files"
This pr also fixes a bug I noticed where "open in new instance" setting was ignored because it was being read from the roaming settings in program.cs, while the setting was saved to local settings.
When Files is launched from the start menu with no event args and "open in new instance" is disabled, it will open the current instance (like Edge does)
NOTE: this will prevent shift+click from opening a new window in the taskbar, so if thats an issue I can undo those changes.