Skip to content

Change windowing/tab behavior when launching Files though different methods #3854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 17, 2021
Merged

Change windowing/tab behavior when launching Files though different methods #3854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f118502
- Added ability to open in new tabs when launched with command line args
winston-de Mar 5, 2021
e36dd6c
Changed label from "When opening File from jumplist" to "When opening…
winston-de Mar 5, 2021
0560f9c
- Changed behavior so a new tab isn't opened if the args are empty
winston-de Mar 5, 2021
b796337
Merge branch 'main' into InstanceFix
tsvietOK Mar 15, 2021
e6e6a84
Reverted to previous behaviour for LaunchActivatedEventArgs
winston-de Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Files/App.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,10 @@ protected override async void OnLaunched(LaunchActivatedEventArgs e)
}
else
{
await MainPage.AddNewTabByPathAsync(typeof(PaneHolderPage), e.Arguments);
if (!(string.IsNullOrEmpty(e.Arguments) && MainPage.AppInstances.Count > 0))
{
await MainPage.AddNewTabByPathAsync(typeof(PaneHolderPage), e.Arguments);
}
}

// Ensure the current window is active
Expand Down
5 changes: 3 additions & 2 deletions Files/MultilingualResources/Files.ar.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,8 +912,9 @@
<target state="translated">افتح المجلد في علامة تبويب جديدة</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="translated">عند إطلاق عنصر من jumplist</target>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">عند إطلاق عنصر من jumplist</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
<trans-unit id="SettingsPreferencesSystemDefaultLanguageOption" translate="yes" xml:space="preserve">
<source>Windows default</source>
Expand Down
5 changes: 3 additions & 2 deletions Files/MultilingualResources/Files.cs-CZ.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,8 +921,9 @@
<target state="translated">Otevřete složku v nové kartě</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="translated">Při spouštění položky z jumplistu</target>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">Při spouštění položky z jumplistu</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
<trans-unit id="SettingsPreferencesSystemDefaultLanguageOption" translate="yes" xml:space="preserve">
<source>Windows default</source>
Expand Down
5 changes: 3 additions & 2 deletions Files/MultilingualResources/Files.da-DK.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,8 +912,9 @@
<target state="translated">Åbn mappe i en ny fane</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="translated">Når du åbner et emne fra jumplisten</target>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">Når du åbner et emne fra jumplisten</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
<trans-unit id="SettingsPreferencesSystemDefaultLanguageOption" translate="yes" xml:space="preserve">
<source>Windows default</source>
Expand Down
5 changes: 3 additions & 2 deletions Files/MultilingualResources/Files.da.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,8 +912,9 @@
<target state="translated">Åbn mappe i en ny fane</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="translated">Når du åbner et emne fra jumplisten</target>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">Når du åbner et emne fra jumplisten</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
<trans-unit id="SettingsPreferencesSystemDefaultLanguageOption" translate="yes" xml:space="preserve">
<source>Windows default</source>
Expand Down
5 changes: 3 additions & 2 deletions Files/MultilingualResources/Files.de-DE.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,8 +856,9 @@
<target state="translated">Seiten:</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="translated">Wenn ein angeheftetes Element gestartet wird</target>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">Wenn ein angeheftetes Element gestartet wird</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
<trans-unit id="SettingsOnStartupLaunchNewInstance.Content" translate="yes" xml:space="preserve">
<source>Always open a new instance</source>
Expand Down
5 changes: 3 additions & 2 deletions Files/MultilingualResources/Files.es-ES.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,8 +855,9 @@
<target state="translated">Páginas</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="translated">Al abrir una carpeta anclada desde la JumpList</target>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">Al abrir una carpeta anclada desde la JumpList</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
<trans-unit id="SettingsOnStartupLaunchNewInstance.Content" translate="yes" xml:space="preserve">
<source>Always open a new instance</source>
Expand Down
5 changes: 3 additions & 2 deletions Files/MultilingualResources/Files.fr-FR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,8 +858,9 @@
<target state="translated">Pages :</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="translated">Lors de l'ouverture d'un élément</target>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">Lors de l'ouverture d'un élément</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
<trans-unit id="SettingsOnStartupLaunchNewInstance.Content" translate="yes" xml:space="preserve">
<source>Always open a new instance</source>
Expand Down
4 changes: 2 additions & 2 deletions Files/MultilingualResources/Files.he-IL.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,8 +856,8 @@
<target state="translated" state-qualifier="tm-suggestion">עמודים</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="new">When launching an item from the jumplist</target>
<source>When opening a folder in Files</source>
<target state="new">When opening a folder in Files</target>
</trans-unit>
<trans-unit id="SettingsOnStartupLaunchNewInstance.Content" translate="yes" xml:space="preserve">
<source>Always open a new instance</source>
Expand Down
2 changes: 1 addition & 1 deletion Files/MultilingualResources/Files.hi-IN.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,7 +866,7 @@
<target state="translated">पन्ने:</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">पिन किए गए फ़ोल्डर को खोलते समय</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
Expand Down
5 changes: 3 additions & 2 deletions Files/MultilingualResources/Files.hu-HU.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,8 +884,9 @@
<target state="translated">Új lapon</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="translated">Elem előzménylistáról megnyitása</target>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">Elem előzménylistáról megnyitása</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
<trans-unit id="SettingsPreferencesSystemDefaultLanguageOption" translate="yes" xml:space="preserve">
<source>Windows default</source>
Expand Down
5 changes: 3 additions & 2 deletions Files/MultilingualResources/Files.it-IT.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,8 +855,9 @@
<target state="translated">Pagine:</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="translated">Quando si avvia una cartella fissata</target>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">Quando si avvia una cartella fissata</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
<trans-unit id="SettingsOnStartupLaunchNewInstance.Content" translate="yes" xml:space="preserve">
<source>Always open a new instance</source>
Expand Down
5 changes: 3 additions & 2 deletions Files/MultilingualResources/Files.ja-JP.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,8 +855,9 @@
<target state="translated">ページ:</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="translated">ジャンプリストから項目を開くとき</target>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">ジャンプリストから項目を開くとき</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
<trans-unit id="SettingsOnStartupLaunchNewInstance.Content" translate="yes" xml:space="preserve">
<source>Always open a new instance</source>
Expand Down
5 changes: 3 additions & 2 deletions Files/MultilingualResources/Files.ko-KR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,8 +835,9 @@
<target state="translated">페이지:</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="translated">점프 목록에서 항목 실행 시</target>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">점프 목록에서 항목 실행 시</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
<trans-unit id="SettingsOnStartupLaunchNewInstance.Content" translate="yes" xml:space="preserve">
<source>Always open a new instance</source>
Expand Down
5 changes: 3 additions & 2 deletions Files/MultilingualResources/Files.nl-NL.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,8 +866,9 @@
<target state="translated">Pagina's:</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="translated">Bij het starten van een item uit de jumplist</target>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">Bij het starten van een item uit de jumplist</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
<trans-unit id="SettingsOnStartupLaunchNewInstance.Content" translate="yes" xml:space="preserve">
<source>Always open a new instance</source>
Expand Down
2 changes: 1 addition & 1 deletion Files/MultilingualResources/Files.or-IN.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,7 +866,7 @@
<target state="translated">ପୃଷ୍ଠାଗୁଡିକ:</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">ଏକ ପିନ୍ ହୋଇଥିବା ଫୋଲ୍ଡର୍ ଲଞ୍ଚ କରିବାବେଳେ</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
Expand Down
4 changes: 2 additions & 2 deletions Files/MultilingualResources/Files.pl-PL.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,8 +856,8 @@
<target state="translated">Strony:</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="translated">Podczas uruchamiania przypiętego folderu</target>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">Podczas uruchamiania przypiętego folderu</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
<trans-unit id="SettingsOnStartupLaunchNewInstance.Content" translate="yes" xml:space="preserve">
Expand Down
5 changes: 3 additions & 2 deletions Files/MultilingualResources/Files.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,8 +851,9 @@
<target state="translated">Páginas:</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="translated">Ao iniciar um item da lista fixada</target>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">Ao iniciar um item da lista fixada</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
<trans-unit id="SettingsOnStartupLaunchNewInstance.Content" translate="yes" xml:space="preserve">
<source>Always open a new instance</source>
Expand Down
5 changes: 3 additions & 2 deletions Files/MultilingualResources/Files.ru-RU.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,8 +855,9 @@
<target state="translated">Страницы:</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="translated">При открытии элемента из списка быстрого запуска</target>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">При открытии элемента из списка быстрого запуска</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
<trans-unit id="SettingsOnStartupLaunchNewInstance.Content" translate="yes" xml:space="preserve">
<source>Always open a new instance</source>
Expand Down
5 changes: 3 additions & 2 deletions Files/MultilingualResources/Files.sv-SE.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,8 +916,9 @@
<target state="translated">Öppna mapp i en ny flik</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="translated">När ett objekt öppnas från Start-menyn eller aktivitetsfältet</target>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">När ett objekt öppnas från Start-menyn eller aktivitetsfältet</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
<trans-unit id="SettingsPreferencesSystemDefaultLanguageOption" translate="yes" xml:space="preserve">
<source>Windows default</source>
Expand Down
2 changes: 1 addition & 1 deletion Files/MultilingualResources/Files.ta.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,7 +860,7 @@
<target state="translated">பக்கங்கள்:</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">பொருத்தப்பட்ட கோப்புறையை இயக்கும்பொது</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
Expand Down
5 changes: 3 additions & 2 deletions Files/MultilingualResources/Files.tr-TR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,8 +851,9 @@
<target state="translated">Sayfa:</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="translated">Sıçrama listesindeki bir öge başlatılırken</target>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">Jumplist'ten bir öğe başlatılırken</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
<trans-unit id="SettingsOnStartupLaunchNewInstance.Content" translate="yes" xml:space="preserve">
<source>Always open a new instance</source>
Expand Down
5 changes: 3 additions & 2 deletions Files/MultilingualResources/Files.uk-UA.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,8 +855,9 @@
<target state="translated">Сторінки:</target>
</trans-unit>
<trans-unit id="SettingsOnStartupNewInstanceBehavior.Text" translate="yes" xml:space="preserve">
<source>When launching an item from the jumplist</source>
<target state="translated">При відкритті елемента зі списку швидкого запуску</target>
<source>When opening a folder in Files</source>
<target state="needs-review-translation">При відкритті елемента зі списку швидкого запуску</target>
<note from="MultilingualUpdate" annotates="source" priority="2">Please verify the translation’s accuracy as the source string was updated after it was translated.</note>
</trans-unit>
<trans-unit id="SettingsOnStartupLaunchNewInstance.Content" translate="yes" xml:space="preserve">
<source>Always open a new instance</source>
Expand Down
Loading