Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show shell items in sidebar context menu #5836

Merged
merged 2 commits into from Aug 17, 2021

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Aug 15, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Show shell context menu items for sidebar
  • Put all shell items in the more submenu to keep menu clean and code simple

Validation
How did you test these changes?

  • Built and ran the app

Copy link
Contributor

@BanCrash BanCrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO in the future this should respect the overflow setting (or remove that setting and respect this style everywhere), but I think it's pointless to waste time right now on that.

Btw LGTM, good job!

@yaira2
Copy link
Member

yaira2 commented Aug 18, 2021

IMO in the future this should respect the overflow setting (or remove that setting and respect this style everywhere), but I think it's pointless to waste time right now on that.

Btw LGTM, good job!

@BanCrash can you open an issue for this so we can implement it in the future?

@BanCrash
Copy link
Contributor

IMO in the future this should respect the overflow setting (or remove that setting and respect this style everywhere), but I think it's pointless to waste time right now on that.
Btw LGTM, good job!

@BanCrash can you open an issue for this so we can implement it in the future?

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants