Skip to content

Add Invert Selection, icons to status bar, fix folder navigation and remove space before .dll #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2020

Conversation

jeffsieu
Copy link
Contributor

@jeffsieu jeffsieu commented Apr 15, 2020

Resolves #601.
Resolves #274.

Previously, when the user navigates into the folder using double click, sometimes it may register as a drag. The program then tries to take the selected files and put it into a DataPackage to start the drag process. But when there are no selected files, the DataPackage throws an error.

This commit adds a check to see if the selected items list is empty. If it is, cancel the drag gesture.

There's also a bug that causes a folder to delete itself, when it is dragged into itself and "skip" is pressed on the dialog that comes afterwards.

Also adds an Invert Selection and some icons to the menu in the status bar.
image

@tsvietOK
Copy link
Contributor

You can test it, just build in release mode. For me it is working fine.

@jeffsieu
Copy link
Contributor Author

@tsvietOK Not sure if this is a problem with my computer, but I used to be able to debug Files just fine in the past after enabling the storage permissions in Windows once. But now I've to keep turning the permissions back on as it seems to reset every time I debug the app... Is this also a problem for you?

@tsvietOK
Copy link
Contributor

@jeffsieu For some reason when debugging VS every time reinstall app as new, so logically we are have to reenable permission every time. This is uncomfortable for me, but i don't think it is a bug

@tsvietOK
Copy link
Contributor

And it is not part of this issue

@jeffsieu
Copy link
Contributor Author

@tsvietOK Okay, I was just wondering if it's my computer because last time I was able to enable it only once...

@ghost ghost added the needs - code review label Apr 15, 2020
Also fixes critical bug where a folder is deleted
if it's moved into itself and the user presses skip
@jeffsieu
Copy link
Contributor Author

I think I found the problem. When the user navigates into the folder using double click, sometimes it may register as a drag. The program then tries to take the selected files and put it into a DataPackage to start the drag process. But when there are no selected files, the DataPackage throws an error.

So I have added a check; if the selected items list is empty, cancel the drag gesture.

@jeffsieu jeffsieu changed the title Remove space before .dll Add Invert Selection, icons to status bar, fix folder navigation and remove space before .dll Apr 15, 2020
@tsvietOK
Copy link
Contributor

Please, add new string to resources(en-US) and build project(it will add new string to xlf files)

@tsvietOK
Copy link
Contributor

tsvietOK commented Apr 15, 2020

@jeffsieu There is another issue with selection, try select folder and unselect it. Now you won't be able to select and open this folder. To select this folder you have to select another folder and then this.

@jeffsieu
Copy link
Contributor Author

jeffsieu commented Apr 15, 2020

@tsvietOK Yes, I also realised that. But I realised that that is already an existing problem in the current develop branch... And I'm not sure why it does that. And seems like it only happens to the grid view.

@lukeblevins
Copy link
Contributor

I like these changes. We'll get around to reviewing them later this week

@lukeblevins lukeblevins self-requested a review April 16, 2020 17:42
@lukeblevins
Copy link
Contributor

@jeffsieu I'm reviewing this now

@lukeblevins lukeblevins merged commit a6b421c into files-community:develop Apr 16, 2020
lukeblevins added a commit that referenced this pull request Apr 16, 2020
* Fix new folder/file creation looses focus with each letter (#607)

* Fix Download folder location (#610)

Get other default folders locations same way

* Don't create folder or file if dialog was canceled (#608)

* Add Invert Selection, icons to status bar, fix folder navigation and remove space before .dll (#604)

* Remove space before .dll

* Add Invert Selection, fix folder navigation crash

Also fixes critical bug where a folder is deleted
if it's moved into itself and the user presses skip

* Add multiligual resources for new string

* Various fixes for v0.7.6 (#611)

* Prevent crash on opening new tab from folder

* Prevent opening multiple new tabs from blocking the UI

* Remove TabView Transition Animations

* Fix Item Thumbnails not Loading

* Ensure file type property is loaded

Co-authored-by: Vladyslav <tsvetkov_vlad@ukr.net>
Co-authored-by: Jeff Sieu <jeffsy00@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants